Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception #1309

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 3, 2022

I backport this for parity with 11.0.17-oracle.

I had to adapt the String literal in PrintLatinCJKTest.java to Java 11 syntax.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
  • JDK-8283712: Create a manual test framework class

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1309/head:pull/1309
$ git checkout pull/1309

Update a local copy of the PR:
$ git checkout pull/1309
$ git pull https://git.openjdk.org/jdk11u-dev pull/1309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1309

View PR using the GUI difftool:
$ git pr show -t 1309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1309.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f26d84f6a03030080328e36a1fd1a08c982838c 8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 3, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284535: Fix PrintLatinCJKTest.java test that is failing with Parse Exception
8283712: Create a manual test framework class

Reviewed-by: phh, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 08e51f5: 8233712: Limit default tests jobs based on ulimit -u setting
  • 761e568: 8291794: [11u] Corrections after backport of JDK-8212028
  • 4046ee2: 8221907: make reconfigure breaks when configured with relative paths
  • 39ec436: 8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2022
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoeLin
Copy link
Member Author

GoeLin commented Aug 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2022

Going to push as commit 1653629.
Since your change was applied there have been 5 commits pushed to the master branch:

  • d6cbc3b: 8283277: ISO 4217 Amendment 171 Update
  • 08e51f5: 8233712: Limit default tests jobs based on ulimit -u setting
  • 761e568: 8291794: [11u] Corrections after backport of JDK-8212028
  • 4046ee2: 8221907: make reconfigure breaks when configured with relative paths
  • 39ec436: 8288928: Incorrect GPL header in pnglibconf.h (backport of JDK-8185041)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 6, 2022
@openjdk openjdk bot closed this Aug 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2022
@openjdk
Copy link

openjdk bot commented Aug 6, 2022

@GoeLin Pushed as commit 1653629.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8284535 branch August 6, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants