Skip to content

8178317: Create man pages using pandoc from markdown sources#1312

Closed
gdams wants to merge 2 commits intoopenjdk:masterfrom
gdams:manpage
Closed

8178317: Create man pages using pandoc from markdown sources#1312
gdams wants to merge 2 commits intoopenjdk:masterfrom
gdams:manpage

Conversation

@gdams
Copy link
Member

@gdams gdams commented Aug 4, 2022

The only diff is in https://github.com/gdams/jdk11u-dev/blob/39b843f26365ce6a5bd5f0ee6d8e1bec57df59d4/make/launcher/LauncherCommon.gmk#L30 which has the additional include (include TextFileProcessing.gmk). Other than that the patch was applied cleanly.

Also includes the patch 8215635: Pandoc check in Docs.gmk does not work on Windows as this no longer seems to have a JBS issue (maybe deleted)

prerequisite to openjdk/jdk@9f1d035 and openjdk/jdk@4f45b5f


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8178317: Create man pages using pandoc from markdown sources

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1312/head:pull/1312
$ git checkout pull/1312

Update a local copy of the PR:
$ git checkout pull/1312
$ git pull https://git.openjdk.org/jdk11u-dev pull/1312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1312

View PR using the GUI difftool:
$ git pr show -t 1312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1312.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2022

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2ddd78e8259652c7c88a5bb7150d7b6ab0e089e2 8178317: Create man pages using pandoc from markdown sources Aug 4, 2022
@openjdk
Copy link

openjdk bot commented Aug 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 4, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2022

Webrevs

@gdams
Copy link
Member Author

gdams commented Aug 4, 2022

closing as no longer needed to backport #1277

@gdams gdams closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant