8210047: some pages contain content outside of landmark region #1320

psoujany · 2022-08-10T13:19:28Z

Backport of 8210047: some pages contain content outside of landmark region

OpenJDK Bug : https://bugs.openjdk.org/browse/JDK-8210047

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8210047: some pages contain content outside of landmark region

Reviewers

Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1320/head:pull/1320
$ git checkout pull/1320

Update a local copy of the PR:
$ git checkout pull/1320
$ git pull https://git.openjdk.org/jdk11u-dev pull/1320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1320

View PR using the GUI difftool:
$ git pr show -t 1320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1320.diff

bridgekeeper · 2022-08-10T13:20:57Z

👋 Welcome back psoujany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-08-10T13:22:40Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2022-08-10T13:28:25Z

Webrevs

00: Full (461646c8)

psoujany · 2022-08-11T04:52:09Z

@RealCLanger Could you please review this backport. Thank you.

RealCLanger · 2022-08-16T12:58:53Z

@psoujany, do you have any hints on what you had to modify for this backport?

psoujany · 2022-08-16T13:28:51Z

@RealCLanger After applying the backport, I've modified the below testcase i.e, TestHtmlVersion.java
https://github.com/openjdk/jdk11u-dev/pull/1320/files#diff-758d666ce824475aacf00bdbd1af556809a342f6fa24eb177e5a4540f11801a5

psoujany · 2022-09-05T09:09:28Z

@RealCLanger Could you please review the PR, thank you.

RealCLanger · 2022-09-07T10:25:45Z

OK, at a glance the PR looks good to me. I'll run it through our testing and let you know the results tomorrow.

psoujany · 2022-09-14T10:10:25Z

@RealCLanger Any updates on testing at your end, could you please review the changes.

RealCLanger

Sorry for the late reply. Testing looks good. Please flag JBS issue for approval.

openjdk · 2022-09-15T12:27:38Z

@psoujany This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210047: some pages contain content outside of landmark region

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

bcdcc9f: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
32d4246: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
9ae65e8: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
19d065b: Merge
e9ba915: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled
ad0878c: 8290209: jcup.md missing additional text
016bfd1: 8279066: entries.remove(entry) is useless in PKCS12KeyStore
6cbaa7f: 8290207: Missing notice in dom.md
6d30812: 8269029: compiler/codegen/TestCharVect2.java fails for client VMs
6784ea0: 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening
... and 45 more: https://git.openjdk.org/jdk11u-dev/compare/74daa996b5212deddc19c806b07f7f1f924ce1e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

psoujany · 2022-09-15T12:47:09Z

@RealCLanger Here's the JBS issue for which review is requested, yet to get the approval.
https://bugs.openjdk.org/browse/JDK-8210047

RealCLanger · 2022-09-15T14:52:36Z

@RealCLanger Here's the JBS issue for which review is requested, yet to get the approval. https://bugs.openjdk.org/browse/JDK-8210047

OK, I take you don't have JBS access? I can add the fix request on your behalf. Can you provide me with some text on why you want to have this backported, risk assessment, testcoverage etc. ?

psoujany · 2022-09-16T06:22:35Z

Yes, I don't have JBS access. JDK11 javadoc generates docs with violations which got fixed in later release i.e 12. Hence requesting this backport which resolves one of those violations. Risk would be moderate as this affects javadoc generation. No regressions shown in Tier1 and javadoc tests from jdk11u-dev.

RealCLanger · 2022-09-16T12:06:47Z

JDK11 javadoc generates docs with violations which got fixed in later release i.e 12. Hence requesting this backport which resolves one of those violations. Risk would be moderate as this affects javadoc generation. No regressions shown in Tier1 and javadoc tests from jdk11u-dev.

OK, I added the JBS item on your behalf. Please monitor it for approval.

GoeLin · 2022-09-22T09:49:36Z

Hi @psoujany, you can integrate now.

psoujany · 2022-09-22T10:19:15Z

/integrate

openjdk · 2022-09-22T10:21:12Z

@psoujany
Your change (at version 461646c) is now ready to be sponsored by a Committer.

RealCLanger · 2022-09-22T10:50:02Z

/sponsor

openjdk · 2022-09-22T10:51:52Z

Going to push as commit 7957658.
Since your change was applied there have been 55 commits pushed to the master branch:

bcdcc9f: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
32d4246: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
9ae65e8: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
19d065b: Merge
e9ba915: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled
ad0878c: 8290209: jcup.md missing additional text
016bfd1: 8279066: entries.remove(entry) is useless in PKCS12KeyStore
6cbaa7f: 8290207: Missing notice in dom.md
6d30812: 8269029: compiler/codegen/TestCharVect2.java fails for client VMs
6784ea0: 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening
... and 45 more: https://git.openjdk.org/jdk11u-dev/compare/74daa996b5212deddc19c806b07f7f1f924ce1e6...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-09-22T10:52:12Z

@RealCLanger @psoujany Pushed as commit 7957658.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

psoujany added 2 commits August 9, 2022 19:04

Backport a17816f

99cd321

Fixed testcase failure

461646c

openjdk bot changed the title ~~Backport a17816f881fadca8dc3bfd49458445873ae762cd~~ 8210047: some pages contain content outside of landmark region Aug 10, 2022

openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 10, 2022

RealCLanger approved these changes Sep 15, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 22, 2022

openjdk bot added the integrated Pull request has been integrated label Sep 22, 2022

openjdk bot closed this Sep 22, 2022

openjdk bot removed the ready Pull request is ready to be integrated label Sep 22, 2022

openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2022

8210047: some pages contain content outside of landmark region #1320

8210047: some pages contain content outside of landmark region #1320

Uh oh!

Conversation

psoujany commented Aug 10, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Aug 10, 2022

Uh oh!

openjdk bot commented Aug 10, 2022

Uh oh!

mlbridge bot commented Aug 10, 2022

Webrevs

Uh oh!

psoujany commented Aug 11, 2022

Uh oh!

RealCLanger commented Aug 16, 2022

Uh oh!

psoujany commented Aug 16, 2022

Uh oh!

psoujany commented Sep 5, 2022

Uh oh!

RealCLanger commented Sep 7, 2022

Uh oh!

psoujany commented Sep 14, 2022

Uh oh!

RealCLanger left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psoujany commented Sep 15, 2022

Uh oh!

RealCLanger commented Sep 15, 2022

Uh oh!

psoujany commented Sep 16, 2022

Uh oh!

RealCLanger commented Sep 16, 2022

Uh oh!

GoeLin commented Sep 22, 2022

Uh oh!

psoujany commented Sep 22, 2022

Uh oh!

openjdk bot commented Sep 22, 2022

Uh oh!

RealCLanger commented Sep 22, 2022

Uh oh!

openjdk bot commented Sep 22, 2022

Uh oh!

openjdk bot commented Sep 22, 2022

Uh oh!

Uh oh!

psoujany commented Aug 10, 2022 •

edited by openjdk bot

Loading

RealCLanger left a comment •

edited

Loading

openjdk bot commented Sep 15, 2022 •

edited

Loading