Skip to content

8214078: (fs) SecureDirectoryStream not supported on arm32 #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Aug 11, 2022

Clean backport. Passes test on our arm32 machine.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8214078: (fs) SecureDirectoryStream not supported on arm32

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1322/head:pull/1322
$ git checkout pull/1322

Update a local copy of the PR:
$ git checkout pull/1322
$ git pull https://git.openjdk.org/jdk11u-dev pull/1322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1322

View PR using the GUI difftool:
$ git pr show -t 1322

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1322.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 11, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2022

Webrevs

@phohensee
Copy link
Member

Please fix the PR/JBS issue title mismatch.

@caojoshua caojoshua changed the title 8214078: SecureDirectoryStream not supported on arm32 8214078: (fs) SecureDirectoryStream not supported on arm32 Aug 11, 2022
@caojoshua
Copy link
Contributor Author

done

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes arm32 same as x86-32. Pre-submit failure on Windows looks unrelated since the code change is Linux-only. Lgtm.

@openjdk
Copy link

openjdk bot commented Aug 11, 2022

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8214078: (fs) SecureDirectoryStream not supported on arm32

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • faf1f86: 7131823: bug in GIFImageReader
  • 44e1ff4: Merge
  • ba80426: Merge jdk-11.0.16.1 into master
  • 63e4b5c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • e068eba: 8292255: Bump update version for OpenJDK: jdk-11.0.16.1
  • 38c632f: 8247546: Pattern matching does not skip correctly over supplementary characters
  • 03a5c25: 8289549: ISO 4217 Amendment 172 Update
  • 7d32ed9: 8209052: Low contrast in docs/api/constant-values.html

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 11, 2022
@phohensee
Copy link
Member

Tagged the JBS issue.

@RealCLanger
Copy link
Contributor

RealCLanger commented Aug 16, 2022

@caojoshua please rename PR to Backport 10cd386ac3508c19bd4e7202a8b07e03dcc0462b to have the bots pick it up correctly.

@caojoshua caojoshua changed the title 8214078: (fs) SecureDirectoryStream not supported on arm32 Backport 10cd386ac3508c19bd4e7202a8b07e03dcc0462b Aug 16, 2022
@openjdk openjdk bot changed the title Backport 10cd386ac3508c19bd4e7202a8b07e03dcc0462b 8214078: (fs) SecureDirectoryStream not supported on arm32 Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

This backport pull request has now been updated with issue from the original commit.

@RealCLanger
Copy link
Contributor

This one is good for integration. GHA issue on Windows seems unrelated.

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@caojoshua
Your change (at version 5e4531a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

Got the approval.

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

Going to push as commit 58076db.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 3db29c4: 8252145: Unify Info.plist files with correct version strings
  • faf1f86: 7131823: bug in GIFImageReader
  • 44e1ff4: Merge
  • ba80426: Merge jdk-11.0.16.1 into master
  • 63e4b5c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • e068eba: 8292255: Bump update version for OpenJDK: jdk-11.0.16.1
  • 38c632f: 8247546: Pattern matching does not skip correctly over supplementary characters
  • 03a5c25: 8289549: ISO 4217 Amendment 172 Update
  • 7d32ed9: 8209052: Low contrast in docs/api/constant-values.html

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2022
@openjdk openjdk bot closed this Aug 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@phohensee @caojoshua Pushed as commit 58076db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants