-
Notifications
You must be signed in to change notification settings - Fork 238
8214078: (fs) SecureDirectoryStream not supported on arm32 #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into |
Please fix the PR/JBS issue title mismatch. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes arm32 same as x86-32. Pre-submit failure on Windows looks unrelated since the code change is Linux-only. Lgtm.
@caojoshua This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Tagged the JBS issue. |
@caojoshua please rename PR to |
This backport pull request has now been updated with issue from the original commit. |
This one is good for integration. GHA issue on Windows seems unrelated. |
/integrate |
@caojoshua |
/sponsor Got the approval. |
Going to push as commit 58076db.
Your commit was automatically rebased without conflicts. |
@phohensee @caojoshua Pushed as commit 58076db. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Passes test on our arm32 machine.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1322/head:pull/1322
$ git checkout pull/1322
Update a local copy of the PR:
$ git checkout pull/1322
$ git pull https://git.openjdk.org/jdk11u-dev pull/1322/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1322
View PR using the GUI difftool:
$ git pr show -t 1322
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1322.diff