8230708: Hotspot fails to build on linux-sparc with gcc-9

[Richard-Rogalski]

Backport of bug 8230708. Tested and worked for me and one other user of sparc/linux.

I signed the OCA: it is under review, will update when it goes through.

This should be fairly low risk: it only touches sparc-specific code.

I appreciate your time :^)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8230708: Hotspot fails to build on linux-sparc with gcc-9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1330/head:pull/1330
$ git checkout pull/1330

Update a local copy of the PR:
$ git checkout pull/1330
$ git pull https://git.openjdk.org/jdk11u-dev pull/1330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1330

View PR using the GUI difftool:
$ git pr show -t 1330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1330.diff

[bridgekeeper]

Hi @Richard-Rogalski, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Richard-Rogalski" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[mlbridge]

Webrevs

• 00: Full (83f33a44)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@Richard-Rogalski This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230708: Hotspot fails to build on linux-sparc with gcc-9

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 42dc282: 8283903: GetContainerCpuLoad does not return the correct result in share mode
• 76cab61: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
• a491f0d: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
• fa8c0d6: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64
• 501352c: 8239423: jdk/jfr/jvm/TestJFRIntrinsic.java failed with -XX:-TieredCompilation
• a77dd69: 8239265: JFR: Test cleanup of jdk.jfr.api.consumer package

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Richard-Rogalski]

/integrate

[openjdk]

@Richard-Rogalski
Your change (at version 83f33a4) is now ready to be sponsored by a Committer.

[RealCLanger]

@Richard-Rogalski Before integrating a PR via /integrate, you need to request maintainer approval by flagging the JBS issue with jdk11u-fix-request and adding a fix request comment, stating why you want to bring in this backport, some risk assessment and state what testing you did. Only when it is approved via the jdk11u-fix-yes label, you are allowed to merge. For some more detailed instruction about the backport process, please consult our Wiki page.

As I assume, you don't have a JBS user account, I can add the request on your behalf. Please write me some text that I can use as fix request comment.

Furthermore, I'd like to ask you to run Github Actions testing as a basic acceptance check. You have to enable Actions on your forked repository. You can trigger a run by merging master into this PR.

Thanks, Christoph

[Richard-Rogalski]

I think I ran the github actions, let me know if that didn't work.

Nope, I don't have an account on the JBS, and I don't see an option to create one: so I appreciate your help :)
Here is what you can use for the comment:

Fix Request 11u

Backporting this patch enables building to sparc/linux with GCC 9. Patch applies cleanly to 11u. This patch is necessary to support jdk11 on gentoo/sparc, as every user builds from source, and GCC 8 has been unmaintained for a while now. This patch has been tested on my and at least one other sparc/linux system, and works as expected.

I appreciate your time and patience =^D

[tstuefe]

@Richard-Rogalski Before integrating a PR via /integrate, you need to request maintainer approval by flagging the JBS issue with jdk11u-fix-request and adding a fix request comment, stating why you want to bring in this backport, some risk assessment and state what testing you did. Only when it is approved via the jdk11u-fix-yes label, you are allowed to merge. For some more detailed instruction about the backport process, please consult our Wiki page.

It is also customary to get a PR reviewed before pushing :-), especially in a maintenance release.

[tstuefe]

@Richard-Rogalski Before integrating a PR via /integrate, you need to request maintainer approval by flagging the JBS issue with jdk11u-fix-request and adding a fix request comment, stating why you want to bring in this backport, some risk assessment and state what testing you did. Only when it is approved via the jdk11u-fix-yes label, you are allowed to merge. For some more detailed instruction about the backport process, please consult our Wiki page.

It is also customary to get a PR reviewed before pushing :-), especially in a maintenance release.

Ah, just seeing this was a clean backport from 14. Okay, no PR review needed then, just JBS approval.

[RealCLanger]

Thanks for running GHA (which looks green) and providing the Fix Request comment. I added the data to the JBS ticket and also approved it. I'll sponsor now.

Thanks for helping to maintain OpenJDK 11u.

/sponsor

[openjdk]

Going to push as commit cbbec73.
Since your change was applied there have been 12 commits pushed to the master branch:

• 01db476: 8282947: JFR: Dump on shutdown live-locks in some conditions
• 1d7b292: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled
• 75e4cb3: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768
• e0d592b: 8275008: gtest build failure due to stringop-overflow warning with gcc11
• 317f79c: 8284950: CgroupV1 detection code should consider memory.swappiness
• 5d344f1: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389
• 42dc282: 8283903: GetContainerCpuLoad does not return the correct result in share mode
• 76cab61: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
• a491f0d: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl
• fa8c0d6: 8242188: error in jtreg test jdk/jfr/api/consumer/TestRecordedFrame.java on linux-aarch64
• ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/ad2e6e4d2526f036a5525913fd529c9a5cf12f0c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @Richard-Rogalski Pushed as commit cbbec73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.