Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275008: gtest build failure due to stringop-overflow warning with gcc11 #1333

Closed
wants to merge 2 commits into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Aug 18, 2022

Backport of c55dd365e3463670697b09de0ff70877203e5a69, which did not apply cleanly due to changes in tip that reworked the make file.

Corretto is requiring this when building as a RPM on a hardened base OS with GCC 11.3


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275008: gtest build failure due to stringop-overflow warning with gcc11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1333/head:pull/1333
$ git checkout pull/1333

Update a local copy of the PR:
$ git checkout pull/1333
$ git pull https://git.openjdk.org/jdk11u-dev pull/1333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1333

View PR using the GUI difftool:
$ git pr show -t 1333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1333.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c55dd365e3463670697b09de0ff70877203e5a69 8275008: gtest build failure due to stringop-overflow warning with gcc11 Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 18, 2022
@lutkerd lutkerd marked this pull request as ready for review August 19, 2022 19:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 19, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@lutkerd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275008: gtest build failure due to stringop-overflow warning with gcc11

Reviewed-by: phh, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 317f79c: 8284950: CgroupV1 detection code should consider memory.swappiness
  • 5d344f1: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389
  • 42dc282: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • 76cab61: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
  • a491f0d: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2022
make/hotspot/lib/CompileGtest.gmk Outdated Show resolved Hide resolved
@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@phohensee The change author (@lutkerd) must issue an integrate command before the integration can be sponsored.

@lutkerd
Copy link
Contributor Author

lutkerd commented Aug 23, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@lutkerd
Your change (at version 60860b4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2022

Going to push as commit e0d592b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 317f79c: 8284950: CgroupV1 detection code should consider memory.swappiness
  • 5d344f1: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389
  • 42dc282: 8283903: GetContainerCpuLoad does not return the correct result in share mode
  • 76cab61: 8279032: compiler/loopopts/TestSkeletonPredicateNegation.java times out with -XX:TieredStopAtLevel < 4
  • a491f0d: 8289569: [test] java/lang/ProcessBuilder/Basic.java fails on Alpine/musl

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2022
@openjdk openjdk bot closed this Aug 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@phohensee @lutkerd Pushed as commit e0d592b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants