Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282947: JFR: Dump on shutdown live-locks in some conditions #1334

Closed

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Aug 19, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1334/head:pull/1334
$ git checkout pull/1334

Update a local copy of the PR:
$ git checkout pull/1334
$ git pull https://git.openjdk.org/jdk11u-dev pull/1334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1334

View PR using the GUI difftool:
$ git pr show -t 1334

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1334.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2022

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 8282947: JFR: Dump on shutdown live-locks in some conditions Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@judovana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 1d7b292: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled
  • 75e4cb3: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768
  • e0d592b: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • 317f79c: 8284950: CgroupV1 detection code should consider memory.swappiness
  • 5d344f1: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2022

Webrevs

@RealCLanger
Copy link
Contributor

@judovana Would you mind to integrate this PR before rampdown of 11.0.17 next week? Thanks!

@judovana
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@judovana
Your change (at version 1dbf008) is now ready to be sponsored by a Committer.

@judovana
Copy link
Contributor Author

Looking for sponsor, if you would be so kind. TYVM!

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

Going to push as commit 01db476.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1d7b292: 8238586: [TESTBUG] vmTestbase/jit/tiered/Test.java failed when TieredCompilation is disabled
  • 75e4cb3: 8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768
  • e0d592b: 8275008: gtest build failure due to stringop-overflow warning with gcc11
  • 317f79c: 8284950: CgroupV1 detection code should consider memory.swappiness
  • 5d344f1: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2022
@openjdk openjdk bot closed this Aug 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@RealCLanger @judovana Pushed as commit 01db476.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants