Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284950: CgroupV1 detection code should consider memory.swappiness #1336

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Aug 22, 2022

Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284950: CgroupV1 detection code should consider memory.swappiness

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1336/head:pull/1336
$ git checkout pull/1336

Update a local copy of the PR:
$ git checkout pull/1336
$ git pull https://git.openjdk.org/jdk11u-dev pull/1336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1336

View PR using the GUI difftool:
$ git pr show -t 1336

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1336.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2022

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 46d208fb1ce9a3d45bee2afda824f15c84a5e4d2 8284950: CgroupV1 detection code should consider memory.swappiness Aug 22, 2022
@openjdk
Copy link

openjdk bot commented Aug 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 22, 2022

@xpbob This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284950: CgroupV1 detection code should consider memory.swappiness

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2022

Webrevs

@xpbob
Copy link
Author

xpbob commented Aug 23, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@xpbob
Your change (at version 1b63705) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2022

Going to push as commit 317f79c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 5d344f1: 8291713: assert(!phase->exceeding_node_budget()) failed: sanity after JDK-8223389

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2022
@openjdk openjdk bot closed this Aug 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2022
@openjdk
Copy link

openjdk bot commented Aug 23, 2022

@DamonFool @xpbob Pushed as commit 317f79c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor

@xpbob, the test case is failing. Did you run this at all when you backported it?

test result: Error. can't find jdk.test.lib.helpers.ClassFileInstaller in test directory or libraries

Looks like ClassFileInstaller lives in another place in 11u.

Please fix this asap! Thanks

@xpbob
Copy link
Author

xpbob commented Aug 24, 2022

@RealCLanger Sorry for this bug. I'll look at it immediately.

@xpbob
Copy link
Author

xpbob commented Aug 24, 2022

@RealCLanger
I fix it in this pr
#1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants