Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768 #1337

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Aug 24, 2022

8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768

Changed the startup command

This test case succeeded on my machine


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1337/head:pull/1337
$ git checkout pull/1337

Update a local copy of the PR:
$ git checkout pull/1337
$ git pull https://git.openjdk.org/jdk11u-dev pull/1337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1337

View PR using the GUI difftool:
$ git pr show -t 1337

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1337.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2022

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 24, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Looks good and trivial.

Please flag the bug with jdk11u-fix-request.

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@xpbob This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292852: [11u] TestMemoryWithCgroupV1 fails after JDK-8292768

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 24, 2022
@xpbob
Copy link
Author

xpbob commented Aug 24, 2022

@RealCLanger
Thanks for review
I've flagged the bug with jdk11u-fix-request

@xpbob
Copy link
Author

xpbob commented Aug 24, 2022

/integrate

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@xpbob
Your change (at version 2bda915) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Aug 24, 2022

Going to push as commit 75e4cb3.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 24, 2022
@openjdk openjdk bot closed this Aug 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 24, 2022
@openjdk
Copy link

openjdk bot commented Aug 24, 2022

@RealCLanger @xpbob Pushed as commit 75e4cb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor

@RealCLanger Thanks for review I've flagged the bug with jdk11u-fix-request

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants