8234510: Remove file seeking requirement for writing a heap dump

[buddyliao]

Backport of the heap dump enhancement: Remove file seeking requirement for writing a heap dump

Patch did not apply cleanly, I had to resolve/modify
src/hotspot/share/services/heapDumper.cpp

I have built it on linux x86_64 and run test-tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8234510: Remove file seeking requirement for writing a heap dump

Reviewers

• Ralf Schmelter (@schmelter-sap - no project role) ⚠️ Review applies to 4b146be
• Christoph Langer (@RealCLanger - Reviewer) ⚠️ Review applies to 6098c61

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/134.diff

[bridgekeeper]

👋 Welcome back buddyliao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (650e623b)
• 01: Full (6098c619)
• 00: Full (4b146be9)

[schmelter-sap]

The change looks good to me. I've run the tier1 and tier2 tests without the problems.

[openjdk]

@buddyliao this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout backport-11c073b97ef03ba46172eb2497c76c3f29b83be8
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[RealCLanger]

@buddyliao, thanks for rebasing. I'll run this through our nightlies and if all goes well I'll approve it then.

[RealCLanger]

No regressions spotted in the nightlies. Good to go from my end.

[openjdk]

⚠️ @buddyliao the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-11c073b97ef03ba46172eb2497c76c3f29b83be8
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@buddyliao This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8234510: Remove file seeking requirement for writing a heap dump

Reviewed-by: rschmelter, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• b878e3f: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
• f2240cc: 8221988: add possibility to build with Visual Studio 2019
• 87e300b: 8220445: Support for side by side MSVC Toolset versions
• d05effd: 8270893: IndexOutOfBoundsException while reading large TIFF file
• d900e31: 8211055: Provide print to a file (PDF) feature even when printer was not connected
• 7751352: 8230808: Remove Access::equals()
• 35fcac6: 8168304: Make all of DependencyContext_test available in product mode
• cf2cf25: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
• 0c783b0: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
• aebdee3: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes
• ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/05c76978a6954897500c3dc8ac6aeca0f23e57cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[buddyliao]

/integrate

[openjdk]

@buddyliao
Your change (at version 650e623) is now ready to be sponsored by a Committer.

[RealCLanger]

/integrate

@buddyliao, you need to Request maintainer approval via jdk11u-fix-request label and Fix request comment in the JBS item JDK-8234510, that part of the protocol hasn't changed with the migration to GitHub.

[linzang]

Dear @RealCLanger,
Thanks for reminder, as @buddyliao doesn't have the access to JBS, I have helped to add the jdk11u-fix-request label in JDK-8234510.

BRs,
Lin

[RealCLanger]

Dear @RealCLanger,
Thanks for reminder, as @buddyliao doesn't have the access to JBS, I have helped to add the jdk11u-fix-request label in JDK-8234510.

BRs,
Lin

Thank you. I approved it and will sponsor this one.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 3d12a46.
Since your change was applied there have been 20 commits pushed to the master branch:

• 1faefed: 8253424: Add support for running pre-submit testing using GitHub Actions
• d780f93: 8249095: tools/javac/launcher/SourceLauncherTest.java fails on Windows
• 90d30cc: 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings
• 9d521b1: 8257913: Add more known library locations to simplify Linux cross-compilation
• 5464d62: 8238930: problem list compiler/c2/Test8004741.java
• 1c77fa8: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
• 52a32a7: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers
• 1223b58: 8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12
• b878e3f: 8263432: javac may report an invalid package/class clash on case insensitive filesystems
• f2240cc: 8221988: add possibility to build with Visual Studio 2019
• ... and 10 more: https://git.openjdk.java.net/jdk11u-dev/compare/05c76978a6954897500c3dc8ac6aeca0f23e57cd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @buddyliao Pushed as commit 3d12a46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.