-
Notifications
You must be signed in to change notification settings - Fork 253
8287663: Add a regression test for JDK-8287073 #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jdk-8287663-11u-backport
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
Backport-of: 2d8c6490540e3ccea23b81129b2e4073915071e0
c233a7c to
4d44e1a
Compare
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
|
Going to push as commit 351508c.
Your commit was automatically rebased without conflicts. |
Clean backport after "JDK-8287107: CgroupSubsystemFactory.setCgroupV2Path asserts with freezer controller". Mostly a regression test, low risk.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1341/head:pull/1341$ git checkout pull/1341Update a local copy of the PR:
$ git checkout pull/1341$ git pull https://git.openjdk.org/jdk11u-dev pull/1341/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1341View PR using the GUI difftool:
$ git pr show -t 1341Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1341.diff