-
Notifications
You must be signed in to change notification settings - Fork 238
8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344 #1344
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
5bda5c7
to
d69b4be
Compare
@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
b64b0f8
to
10fca97
Compare
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout RealCLanger-backport-01f93ddf
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@RealCLanger Pushed as commit c9f3135. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Follow up after JDK-8278344.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1344/head:pull/1344
$ git checkout pull/1344
Update a local copy of the PR:
$ git checkout pull/1344
$ git pull https://git.openjdk.org/jdk11u-dev pull/1344/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1344
View PR using the GUI difftool:
$ git pr show -t 1344
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1344.diff