6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

[macarte]

Backport of e3c178d

On Windows you can now access the local machine keystores using the strings "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the application requires admin privileges.

"Windows-MY" and "Windows-ROOT" remain unchanged, however given these original keystore strings mapped to the current user, I added "Windows-MY-CURRENTUSER" and "Windows-ROOT-CURRENTUSER" so that a developer can explicitly specify the current user location. These two new strings simply map to the original two strings, i.e. no duplication of code paths etc

keystore functionality and API remains unchanged, the local machine keystore types require the manual tests to run in admin mode

Tested on windows, passes tier1 (via GH Actions) and manual tests provided in the patch

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-6782021: It is not possible to read local computer certificates with the SunMSCAPI provider
• JDK-8284850: It is not possible to read local computer certificates with the SunMSCAPI provider (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1348/head:pull/1348
$ git checkout pull/1348

Update a local copy of the PR:
$ git checkout pull/1348
$ git pull https://git.openjdk.org/jdk11u-dev pull/1348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1348

View PR using the GUI difftool:
$ git pr show -t 1348

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1348.diff

[bridgekeeper]

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@macarte This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6782021: It is not possible to read local computer certificates with the SunMSCAPI provider

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 78ba1e5: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
• 2548ed3: 8242468: VS2019 build missing vcruntime140_1.dll
• 75b3e45: 8239708: Split basics.m4 into basic.m4 and util.m4
• de5b4b4: 8217032: Check pandoc capabilities in configure
• de91323: 8292083: Detected container memory limit may exceed physical machine memory
• 6e30d22: 8292887: Bump update version for OpenJDK: jdk-11.0.18
• 2f0f34c: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
• 9186b3c: 8287463: JFR: Disable TestDevNull.java on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (7e53fd85)

[macarte]

/integrate

[openjdk]

@macarte
Your change (at version 7e53fd8) is now ready to be sponsored by a Committer.

[macarte]

@RealCLanger - would you mind sponsoring this backport, this is the last backport for this patch

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit f75b74d.
Since your change was applied there have been 8 commits pushed to the master branch:

• 78ba1e5: 8247676: vcruntime140_1.dll is not needed on 32-bit Windows
• 2548ed3: 8242468: VS2019 build missing vcruntime140_1.dll
• 75b3e45: 8239708: Split basics.m4 into basic.m4 and util.m4
• de5b4b4: 8217032: Check pandoc capabilities in configure
• de91323: 8292083: Detected container memory limit may exceed physical machine memory
• 6e30d22: 8292887: Bump update version for OpenJDK: jdk-11.0.18
• 2f0f34c: 8291570: [TESTBUG] Part of JDK-8250984 absent from 11u
• 9186b3c: 8287463: JFR: Disable TestDevNull.java on Windows

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @macarte Pushed as commit f75b74d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.