New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening #1350
Conversation
Hi @rccha, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rccha" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
This backport pull request has now been updated with issue from the original commit. |
I can verify that Ruhesh is an Amazon employee and therefore covered under the OCA. |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@rccha This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.
|
JBS issue tagged. A 17u backport would be a good idea. |
Definitely. Please do 17u before 11u. |
/integrate |
/sponsor 17u backport done, got the approval. |
Going to push as commit 6784ea0.
Your commit was automatically rebased without conflicts. |
@phohensee @rccha Pushed as commit 6784ea0. |
Backport for JDK-8274563
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1350/head:pull/1350
$ git checkout pull/1350
Update a local copy of the PR:
$ git checkout pull/1350
$ git pull https://git.openjdk.org/jdk11u-dev pull/1350/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1350
View PR using the GUI difftool:
$ git pr show -t 1350
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1350.diff