-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269029: compiler/codegen/TestCharVect2.java fails for client VMs #1357
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 307 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Pre-submit tests: MineField.sh fails, I saw this in several runs lately. Unrelated |
/integrate |
Going to push as commit 6d30812.
Your commit was automatically rebased without conflicts. |
Simple resolve, original change has an additional arg in the context lines.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1357/head:pull/1357
$ git checkout pull/1357
Update a local copy of the PR:
$ git checkout pull/1357
$ git pull https://git.openjdk.org/jdk11u-dev pull/1357/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1357
View PR using the GUI difftool:
$ git pr show -t 1357
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1357.diff