Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening #1364

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Sep 21, 2022

Backport for JDK-8293828


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1364/head:pull/1364
$ git checkout pull/1364

Update a local copy of the PR:
$ git checkout pull/1364
$ git pull https://git.openjdk.org/jdk11u-dev pull/1364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1364

View PR using the GUI difftool:
$ git pr show -t 1364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1364.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

@phohensee
Copy link
Member

Please change the PR title to "Backport d203b357465cf8fe033808e006c83f910696adf6" so the bot recognizes it as a backport.

@phohensee
Copy link
Member

Please configure pre-submit testing. See https://wiki.openjdk.org/display/SKARA/Testing.

@Rudometov Rudometov changed the title 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Backport d203b357465cf8fe033808e006c83f910696adf6 Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

⚠️ @Rudometov could not find any commit with hash d203b357465cf8fe033808e006c83f910696adf6. Please update the title with the hash for an existing commit.

@Rudometov Rudometov changed the title Backport d203b357465cf8fe033808e006c83f910696adf6 Backport 5002eaa5cc7301b91a45f8c0f65b5943fea225d8 Sep 21, 2022
@openjdk openjdk bot changed the title Backport 5002eaa5cc7301b91a45f8c0f65b5943fea225d8 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • dab4c44: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • 7957658: 8210047: some pages contain content outside of landmark region
  • bcdcc9f: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
  • 32d4246: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
  • 9ae65e8: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
  • 19d065b: Merge
  • e9ba915: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2022
@phohensee
Copy link
Member

Apologies for getting the hash wrong. JBS issue tagged.

@phohensee
Copy link
Member

Victor, please add a "/integrate" comment so I can sponsor the commit.

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@Rudometov
Your change (at version e318d0a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 22, 2022

Going to push as commit b5dbfef.
Since your change was applied there have been 7 commits pushed to the master branch:

  • dab4c44: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox
  • 7957658: 8210047: some pages contain content outside of landmark region
  • bcdcc9f: 8240281: Remove failing assertion code when selecting first memory state in SuperWord::co_locate_pack
  • 32d4246: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
  • 9ae65e8: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint
  • 19d065b: Merge
  • e9ba915: 8275887: jarsigner prints invalid digest/signature algorithm warnings if keysize is weak/disabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2022
@openjdk openjdk bot closed this Sep 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2022
@openjdk
Copy link

openjdk bot commented Sep 22, 2022

@phohensee @Rudometov Pushed as commit b5dbfef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants