Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative #1366

Closed
wants to merge 1 commit into from

Conversation

YaaZ
Copy link
Member

@YaaZ YaaZ commented Sep 21, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1366/head:pull/1366
$ git checkout pull/1366

Update a local copy of the PR:
$ git checkout pull/1366
$ git pull https://git.openjdk.org/jdk11u-dev pull/1366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1366

View PR using the GUI difftool:
$ git pr show -t 1366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1366.diff

…t.CFont.getTableBytesNative

Reviewed-by: prr
(cherry picked from commit 8c460b043e1cbaf1f2d74958033bb24dea66a390)
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2022

👋 Welcome back YaaZ! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8c460b043e1cbaf1f2d74958033bb24dea66a390 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative Sep 21, 2022
@openjdk
Copy link

openjdk bot commented Sep 21, 2022

This backport pull request has now been updated with issue from the original commit.

@YaaZ
Copy link
Member Author

YaaZ commented Sep 21, 2022

As #1203 was closed by timeout

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

@YaaZ This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 241 new commits pushed to the master branch:

  • 8fadf3d: 8292158: AES-CTR cipher state corruption with AVX-512
  • 16a4bd3: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...
  • 523ef55: 8282777: Create a Regression test for JDK-4515031
  • 957a888: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • e864cfc: 8282778: Create a regression test for JDK-4699544
  • 74bc485: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 31d178b: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • c064dce: 8274597: Some of the dnd tests time out and fail intermittently
  • 9ffc4b3: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • fb08d9d: 8282937: Write a regression test for JDK-4820080
  • ... and 231 more: https://git.openjdk.org/jdk11u-dev/compare/7a076e47b162d8d9e70dac3ab8fca3e10102ee6d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Sep 21, 2022

⚠️ @YaaZ a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 7a076e47b162d8d9e70dac3ab8fca3e10102ee6d
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2022

Webrevs

@phohensee
Copy link
Member

@YaaZ, please label JDK-8287609 with jdk11u-fix-request and add a "Fix Request (11u)" comment.

@YaaZ
Copy link
Member Author

YaaZ commented Sep 26, 2022

@phohensee done.

@GoeLin
Copy link
Member

GoeLin commented Sep 29, 2022

@YaaZ, you also should enable the tests here!

@YaaZ
Copy link
Member Author

YaaZ commented Sep 29, 2022

@GoeLin but I did enable them.

@phohensee
Copy link
Member

@YaaZ, please add a "/integrate" comment.

@YaaZ
Copy link
Member Author

YaaZ commented Oct 14, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@YaaZ
Your change (at version 96f6280) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit 7b3b204.
Since your change was applied there have been 242 commits pushed to the master branch:

  • fb364db: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 8fadf3d: 8292158: AES-CTR cipher state corruption with AVX-512
  • 16a4bd3: 8288599: com/sun/management/OperatingSystemMXBean/TestTotalSwap.java: Expected total swap size ... but getTotalSwapSpaceSize returned ...
  • 523ef55: 8282777: Create a Regression test for JDK-4515031
  • 957a888: 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray
  • e864cfc: 8282778: Create a regression test for JDK-4699544
  • 74bc485: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 31d178b: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • c064dce: 8274597: Some of the dnd tests time out and fail intermittently
  • 9ffc4b3: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • ... and 232 more: https://git.openjdk.org/jdk11u-dev/compare/7a076e47b162d8d9e70dac3ab8fca3e10102ee6d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@phohensee @YaaZ Pushed as commit 7b3b204.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants