New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249781: AArch64: AOT compiled code crashes if C2 allocates r27 #138
Conversation
👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into |
PR for the main issue #137 |
This backport pull request has now been updated with issue from the original commit. |
@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@dchuyko This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 408 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@dchuyko This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Leading issue JDK-8242449 got jdk11u-fix-no so not proceeding with this one. |
This is a post-fix for JDK-8242449.
Original patch has been adjusted to use Universe::narrow_ptrs_base() instead of CompressedOops::ptrs_base() (no JDK-8223136).
This PR is a combination of JDK-8233743 + JDK-8242449 + JDK-8249781.
Testing: tier1, tier2 (aarch64).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/138/head:pull/138
$ git checkout pull/138
Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/138/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 138
View PR using the GUI difftool:
$ git pr show -t 138
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/138.diff