Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249781: AArch64: AOT compiled code crashes if C2 allocates r27 #138

Closed
wants to merge 3 commits into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Jul 15, 2021

This is a post-fix for JDK-8242449.
Original patch has been adjusted to use Universe::narrow_ptrs_base() instead of CompressedOops::ptrs_base() (no JDK-8223136).

This PR is a combination of JDK-8233743 + JDK-8242449 + JDK-8249781.

Testing: tier1, tier2 (aarch64).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249781: AArch64: AOT compiled code crashes if C2 allocates r27

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/138.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2021

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dchuyko
Copy link
Member Author

dchuyko commented Jul 15, 2021

PR for the main issue #137

@openjdk openjdk bot changed the title Backport 22006dceb4e13299b9213720d2298039c57a7882 8249781: AArch64: AOT compiled code crashes if C2 allocates r27 Jul 15, 2021
@openjdk
Copy link

openjdk bot commented Jul 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 15, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2021

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2021

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@dchuyko This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249781: AArch64: AOT compiled code crashes if C2 allocates r27

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 408 new commits pushed to the master branch:

  • 25c33bc: 8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled
  • 00255bd: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
  • 1297c26: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag
  • 4b6e487: 8197800: Test java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java fails on Windows
  • 5a2b2ac: 8198619: java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java fails on mac
  • b449303: 8171998: javax/swing/JMenu/4692443/bug4692443.java fails on Windows
  • cdc48c2: 8256201: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java failed
  • 93e98ad: 8266579: Update test/jdk/java/lang/ProcessHandle/PermissionTest.java & test/jdk/java/sql/testng/util/TestPolicy.java
  • 1772cf1: 8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
  • 0f9d6bf: 8247510: typo in IllegalHandshakeMessage
  • ... and 398 more: https://git.openjdk.java.net/jdk11u-dev/compare/2252165499c4246de281f56609a3d4910605f7c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2021

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2021

@dchuyko This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 18, 2021
Copy link
Contributor

@theRealAph theRealAph left a comment

.

@dchuyko
Copy link
Member Author

dchuyko commented Dec 21, 2021

Leading issue JDK-8242449 got jdk11u-fix-no so not proceeding with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants