New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293044: C1: Missing access check on non-accessible class #1384
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just an unrelated change in the context. LGTM. Thanks for backporting!
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing aarch64. LGTM.
/integrate |
Going to push as commit 3622c42.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.18-oracle.
I had to resolve c1_Runtime.cpp.
For example, JRT_ENTRY(...) was removed in 17.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1384/head:pull/1384
$ git checkout pull/1384
Update a local copy of the PR:
$ git checkout pull/1384
$ git pull https://git.openjdk.org/jdk11u-dev pull/1384/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1384
View PR using the GUI difftool:
$ git pr show -t 1384
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1384.diff