Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267459: Pasting Unicode characters into JShell does not work. #139

Closed
wants to merge 1 commit into from

Conversation

takiguc
Copy link

@takiguc takiguc commented Jul 19, 2021

Hello

Original bug:
https://bugs.openjdk.java.net/browse/JDK-8267459
openjdk/jdk@de6472c

Original patch does not apply cleanly to 11u, because 8267459 requires following order
8241950: JShell could support auto-indent
8247932: JShell crashes when typing text block
8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder
8267459: Pasting Unicode characters into JShell does not work

8241950 and 8247932 are enhancement code including "Text Blocks" which is not supported by JDK11.
8247403 is ported to 11.0.13-oracle.
But I could not recreate 8247403 by myself.
So I'd like to just send backport for 8267459.

I need to change test/langtools/jdk/jshell/UITesting.java.
Because following code was added by 8247403.

import java.lang.reflect.Field;

Testing: tier1 and tier2 were passed

Thanks,


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267459: Pasting Unicode characters into JShell does not work.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/139/head:pull/139
$ git checkout pull/139

Update a local copy of the PR:
$ git checkout pull/139
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 139

View PR using the GUI difftool:
$ git pr show -t 139

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/139.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2021

👋 Welcome back itakiguchi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8267459: Pasting Unicode characters into JShell does not work 8267459: Pasting Unicode characters into JShell does not work. Jul 19, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2021
@takiguc
Copy link
Author

takiguc commented Jul 19, 2021

/label add kulla

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@takiguc The label kulla is not a valid label. These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Jul 19, 2021

Webrevs

@RealCLanger
Copy link
Contributor

RealCLanger commented Jul 19, 2021

@takiguc To get this PR properly recognized as backport, please change the title to "Backport de6472c". The bots will then correctly resolve it and it can be reviewed.

@takiguc takiguc changed the title 8267459: Pasting Unicode characters into JShell does not work. Backport de6472c44166e57cd440b7bffcfc876585aca7dd Jul 19, 2021
@openjdk openjdk bot changed the title Backport de6472c44166e57cd440b7bffcfc876585aca7dd 8267459: Pasting Unicode characters into JShell does not work. Jul 19, 2021
@openjdk
Copy link

openjdk bot commented Jul 19, 2021

This backport pull request has now been updated with issue from the original commit.

@takiguc
Copy link
Author

takiguc commented Jul 19, 2021

Thanks, @RealCLanger .

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@takiguc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267459: Pasting Unicode characters into JShell does not work.

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2021
Copy link
Contributor

@RealCLanger RealCLanger left a comment

Seems like the bots identify it as clean :)

@takiguc
Copy link
Author

takiguc commented Jul 19, 2021

@RealCLanger , many thanks.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

Going to push as commit dff3b7f.

@openjdk openjdk bot closed this Jul 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2021
@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@takiguc Pushed as commit dff3b7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants