New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8243565: some gc tests use 'test.java.opts' and not 'test.vm.opts' #1395
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
0d412d3
to
6c22634
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks for the review! |
/integrate |
Going to push as commit 3ce188b.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.17-oracle.
TestUseCompressedOopsErgo.java has two additional test cases I had to resolve.
nvdimm tests are not in 11.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1395/head:pull/1395
$ git checkout pull/1395
Update a local copy of the PR:
$ git checkout pull/1395
$ git pull https://git.openjdk.org/jdk11u-dev pull/1395/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1395
View PR using the GUI difftool:
$ git pr show -t 1395
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1395.diff