Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210495: compiler crashes because of illegal signature in otherwise legal code #14

Closed

Conversation

adityamandaleeka
Copy link
Contributor

@adityamandaleeka adityamandaleeka commented Jun 4, 2021

This is a backport of 8210495.

Fix request for 11u approved here: https://bugs.openjdk.java.net/browse/JDK-8210495


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8210495: compiler crashes because of illegal signature in otherwise legal code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/14.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2021

👋 Welcome back adityam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c0d51dc51425f877e76aa4c4407719d67f2f9485 8210495: compiler crashes because of illegal signature in otherwise legal code Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 4, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@adityamandaleeka This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210495: compiler crashes because of illegal signature in otherwise legal code

Disable strict verification of compiler signatures when they do not affect generated bytecode

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e6d0e9d: 8266642: Improve ResolvedMethodTable hash function
  • 5c35022: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2021
Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can sponsor this.

@adityamandaleeka
Copy link
Contributor Author

Thanks @RealCLanger.

/integrate

@adityamandaleeka
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@adityamandaleeka
Your change (at version 565cf12) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@adityamandaleeka
Your change (at version 565cf12) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@RealCLanger @adityamandaleeka Since your change was applied there have been 5 commits pushed to the master branch:

  • e6d0e9d: 8266642: Improve ResolvedMethodTable hash function
  • 5c35022: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86

Your commit was automatically rebased without conflicts.

Pushed as commit f55ef1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants