Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294357: (tz) Update Timezone Data to 2022d #1405

Closed
wants to merge 1 commit into from

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Oct 7, 2022

Same changes as jdk17u, just some files that were moved in 19:
new: src/java.base/share/data/tzdata
old: make/data/tzdata
Otherwise, clean patch.
Will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1405/head:pull/1405
$ git checkout pull/1405

Update a local copy of the PR:
$ git checkout pull/1405
$ git pull https://git.openjdk.org/jdk11u-dev pull/1405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1405

View PR using the GUI difftool:
$ git pr show -t 1405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1405.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2022

👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f01573368f905f27d26f1d07d9cfd26dcc736a54 8294357: (tz) Update Timezone Data to 2022d Oct 8, 2022
@openjdk
Copy link

openjdk bot commented Oct 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 8, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2022

Webrevs

@alvdavi
Copy link
Contributor Author

alvdavi commented Oct 8, 2022

/clean

@openjdk
Copy link

openjdk bot commented Oct 8, 2022

@alvdavi Only OpenJDK Committers can use the /clean command

@phohensee
Copy link
Member

/clean

@openjdk openjdk bot added the clean label Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@phohensee This backport pull request is now marked as clean

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@alvdavi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8294357: (tz) Update Timezone Data to 2022d

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 4566c88: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 4be6963: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 380cbc8: 8284521: Write an automated regression test for RFE 4371575
  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • fbaf2f2: 8282640: Create a test for JDK-4740761
  • 01cc71f: 8284294: Create an automated regression test for RFE 4138746
  • 910546f: 8283422: Create a new test for JDK-8254790
  • 0910bdb: 8282046: Create a regression test for JDK-8000326
  • ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/0013d849ff851fe180bfb0b6aeb5e868cf042568...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2022

Hi @alvdavi
If you use the change pushed to 17 for backport, you don't have to redo the file move.
It will probably be clean right away.
You can simply type /backport jdk11u-dev in the change in jdk17u-dev: openjdk/jdk17u-dev@3d93fdc
This saves work and reduces the chance of errors.

@alvdavi
Copy link
Contributor Author

alvdavi commented Oct 11, 2022

Thanks, I'll take this into consideration for future backports

@alvdavi
Copy link
Contributor Author

alvdavi commented Oct 11, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@alvdavi
Your change (at version dfe20d8) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit f67b4de.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 4566c88: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 4be6963: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 380cbc8: 8284521: Write an automated regression test for RFE 4371575
  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • fbaf2f2: 8282640: Create a test for JDK-4740761
  • 01cc71f: 8284294: Create an automated regression test for RFE 4138746
  • 910546f: 8283422: Create a new test for JDK-8254790
  • 0910bdb: 8282046: Create a regression test for JDK-8000326
  • ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/0013d849ff851fe180bfb0b6aeb5e868cf042568...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@phohensee @alvdavi Pushed as commit f67b4de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants