Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254967: com.sun.net.HttpsServer spins on TLS session close #141

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 19, 2021

Clean backport of JDK-8254967.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8254967: com.sun.net.HttpsServer spins on TLS session close

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/141.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 19, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 953e472dedf55bc1a831af36637547b5a1fd7af7 8254967: com.sun.net.HttpsServer spins on TLS session close Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254967: com.sun.net.HttpsServer spins on TLS session close

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jul 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 19, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 20, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

Going to push as commit 2696643.

@openjdk openjdk bot closed this Jul 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 20, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8254967_httpserver branch Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

@TheRealMDoerr Pushed as commit 2696643.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant