New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282345: handle latest VS2022 in abstract_vm_version #1417
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, keeping the old VS2010/VS2012 makes sense for jdk11 .
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit 1d9108f.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.18-oracle.
Clean except for copyright.
But I do not want to drop support for old compilers in this rather old release,
so I did not remove the corresponding code.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1417/head:pull/1417
$ git checkout pull/1417
Update a local copy of the PR:
$ git checkout pull/1417
$ git pull https://git.openjdk.org/jdk11u-dev pull/1417/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1417
View PR using the GUI difftool:
$ git pr show -t 1417
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1417.diff