Skip to content

8284521: Write an automated regression test for RFE 4371575 #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 10, 2022

I backport this for parity with 11.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284521: Write an automated regression test for RFE 4371575

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1427/head:pull/1427
$ git checkout pull/1427

Update a local copy of the PR:
$ git checkout pull/1427
$ git pull https://git.openjdk.org/jdk11u-dev pull/1427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1427

View PR using the GUI difftool:
$ git pr show -t 1427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1427.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 447c2d13d055fbe640ec4714a961543a03a4f2ad 8284521: Write an automated regression test for RFE 4371575 Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284521: Write an automated regression test for RFE 4371575

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 094ca71: 8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points
  • 57c1b21: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails
  • df5f253: 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI
  • 3b9e482: 8211002: test/jdk/java/lang/Math/PowTests.java skips testing for non-corner-case values
  • b6bf677: 8269873: serviceability/sa/Clhsdb tests are using a C2 specific VMStruct field
  • a84c773: 8263326: Remove ReceiverTypeData check from serviceability/sa/TestPrintMdo.java
  • f7e6d0d: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
  • c9d5eb3: 8253877: gc/g1/TestGCLogMessages.java fails - missing "Evacuation failure" message
  • 4b2941d: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
  • a48bd87: 8249694: java/lang/StringBuffer/HugeCapacity.java and j/l/StringBuilder/HugeCapacity.java tests shouldn't be @Ignore-d
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 11, 2022

Pre-submit test failure: timeout in a test other than the one added here. Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit 380cbc8.
Since your change was applied there have been 31 commits pushed to the master branch:

  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • fbaf2f2: 8282640: Create a test for JDK-4740761
  • 01cc71f: 8284294: Create an automated regression test for RFE 4138746
  • 910546f: 8283422: Create a new test for JDK-8254790
  • 0910bdb: 8282046: Create a regression test for JDK-8000326
  • ec5041e: 8282936: Write a regression test for JDK-4615365
  • 5a3e86c: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • f614119: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also
  • df6d5f8: 4819544: SwingSet2 JTable Demo throws NullPointerException
  • ... and 21 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin Pushed as commit 380cbc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant