Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java #1430

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Oct 10, 2022

Backport for parity with Oracle.

Fix conflict in ProblemList.txt. Clean backport otherwise.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1430/head:pull/1430
$ git checkout pull/1430

Update a local copy of the PR:
$ git checkout pull/1430
$ git pull https://git.openjdk.org/jdk11u-dev pull/1430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1430

View PR using the GUI difftool:
$ git pr show -t 1430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1430.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f5beafa53f93a6ec03278dfd7063d7b3b0b9d241 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 380cbc8: 8284521: Write an automated regression test for RFE 4371575
  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • fbaf2f2: 8282640: Create a test for JDK-4740761
  • 01cc71f: 8284294: Create an automated regression test for RFE 4138746
  • 910546f: 8283422: Create a new test for JDK-8254790
  • 0910bdb: 8282046: Create a regression test for JDK-8000326
  • ec5041e: 8282936: Write a regression test for JDK-4615365
  • 5a3e86c: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • ... and 23 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2022

Webrevs

@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@caojoshua
Your change (at version a0fbba5) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit 4be6963.
Since your change was applied there have been 33 commits pushed to the master branch:

  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • 380cbc8: 8284521: Write an automated regression test for RFE 4371575
  • a6fafe8: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • 01d99fa: 8284732: FFI_GO_CLOSURES macro not defined but required for zero build on Mac OS X
  • fbaf2f2: 8282640: Create a test for JDK-4740761
  • 01cc71f: 8284294: Create an automated regression test for RFE 4138746
  • 910546f: 8283422: Create a new test for JDK-8254790
  • 0910bdb: 8282046: Create a regression test for JDK-8000326
  • ec5041e: 8282936: Write a regression test for JDK-4615365
  • 5a3e86c: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
  • ... and 23 more: https://git.openjdk.org/jdk11u-dev/compare/9014a180dc9656099a89e597c4dba31a41b68ad1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@phohensee @caojoshua Pushed as commit 4be6963.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants