Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274597: Some of the dnd tests time out and fail intermittently #1437

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 11, 2022

I backport this for parity with 11.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8274597: Some of the dnd tests time out and fail intermittently
  • JDK-8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1437/head:pull/1437
$ git checkout pull/1437

Update a local copy of the PR:
$ git checkout pull/1437
$ git pull https://git.openjdk.org/jdk11u-dev pull/1437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1437

View PR using the GUI difftool:
$ git pr show -t 1437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1437.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 669ac611b269bbda5c53d84173e5c9d0eb4ce919 8274597: Some of the dnd tests time out and fail intermittently Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274597: Some of the dnd tests time out and fail intermittently
8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

@RealCLanger
Copy link
Contributor

@GoeLin No GHA tests? Maybe you need to enable them on the bots repo?

@GoeLin
Copy link
Member Author

GoeLin commented Oct 12, 2022

@RealCLanger
I sure have them enabled :) See #1439 .
I did 396 backports with the bots repo :P.
If they were not enabled, there would be a message about this.
Something went wrong: https://github.com/openjdk-bots/jdk11u-dev/actions/runs/3225146702

@RealCLanger
Copy link
Contributor

@RealCLanger I sure have them enabled :) See #1439 . I did 396 backports with the bots repo :P. If they were not enabled, there would be a message about this. Something went wrong: https://github.com/openjdk-bots/jdk11u-dev/actions/runs/3225146702

Yep, I thought so. 😄 And later on I saw other PRs where it worked. So must have been a glitch in the system. Thx

@GoeLin
Copy link
Member Author

GoeLin commented Oct 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

Going to push as commit c064dce.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 9ffc4b3: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • fb08d9d: 8282937: Write a regression test for JDK-4820080
  • 1d9108f: 8282345: handle latest VS2022 in abstract_vm_version
  • 81e900a: 8233557: [TESTBUG] DoubleClickTitleBarTest.java fails on macOs
  • 64a3b18: 8244010: Simplify usages of ProcessTools.createJavaProcessBuilder in our tests
  • 605e390: 8281296: Create a regression test for JDK-4515999
  • f67b4de: 8294357: (tz) Update Timezone Data to 2022d
  • 4566c88: 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos
  • 4be6963: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java
  • dde80ab: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/9ddc8b02fa7632a3d4b8f24484a1ecbda3b247bc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2022
@openjdk openjdk bot closed this Oct 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@GoeLin Pushed as commit c064dce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants