Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray #1440

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 11, 2022

I backport this for parity with 11.0.18-oracle.

I had to resovle copyright. Will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1440/head:pull/1440
$ git checkout pull/1440

Update a local copy of the PR:
$ git checkout pull/1440
$ git pull https://git.openjdk.org/jdk11u-dev pull/1440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1440

View PR using the GUI difftool:
$ git pr show -t 1440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1440.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9b9831f2a88ed3b7701d402b167a096b94aeb98 8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 11, 2022

/clean

@openjdk openjdk bot added the clean label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286663: Resolve IDE warnings in WTrayIconPeer and SystemTray

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

Going to push as commit 957a888.
Since your change was applied there have been 13 commits pushed to the master branch:

  • e864cfc: 8282778: Create a regression test for JDK-4699544
  • 74bc485: 8287091: aarch64 : guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 31d178b: 8281297: TestStressG1Humongous fails with guarantee(is_range_uncommitted)
  • c064dce: 8274597: Some of the dnd tests time out and fail intermittently
  • 9ffc4b3: 8284752: Zero does not build on Mac OS X due to missing os::current_thread_enable_wx implementation
  • fb08d9d: 8282937: Write a regression test for JDK-4820080
  • 1d9108f: 8282345: handle latest VS2022 in abstract_vm_version
  • 81e900a: 8233557: [TESTBUG] DoubleClickTitleBarTest.java fails on macOs
  • 64a3b18: 8244010: Simplify usages of ProcessTools.createJavaProcessBuilder in our tests
  • 605e390: 8281296: Create a regression test for JDK-4515999
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/dde80ab85a53cbe6a1ed38e0911c5bf16f2a8248...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2022
@openjdk openjdk bot closed this Oct 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@GoeLin Pushed as commit 957a888.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8286663 branch October 12, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant