Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225690: Multiple AttachListener threads can be created #145

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 20, 2021

Clean backport of JDK-8225690.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8225690: Multiple AttachListener threads can be created

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/145/head:pull/145
$ git checkout pull/145

Update a local copy of the PR:
$ git checkout pull/145
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 145

View PR using the GUI difftool:
$ git pr show -t 145

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/145.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 20, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8225690 8225690: Multiple AttachListener threads can be created Jul 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 20, 2021

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added backport rfr labels Jul 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 20, 2021

Webrevs

@TheRealMDoerr TheRealMDoerr changed the title 8225690: Multiple AttachListener threads can be created Backport 2870c9d55efe3c0ba9375425efe538912c47bac1 Jul 22, 2021
@openjdk openjdk bot changed the title Backport 2870c9d55efe3c0ba9375425efe538912c47bac1 8225690: Multiple AttachListener threads can be created Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

This backport pull request has now been updated with issue from the original commit.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Looks good. Unfortunately you didn't base it on the git commit so the bots don't recognize that it is clean. Better do this next time :)

@openjdk openjdk bot added the clean label Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8225690: Multiple AttachListener threads can be created

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 22, 2021
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 22, 2021

Now, the bot got it. Thanks for the review and the approval!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

Going to push as commit f3098c4.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 22, 2021

@TheRealMDoerr Pushed as commit f3098c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8225690_AttachListener branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants