Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291461: assert(false) failed: bad AD file #1459

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 13, 2022

Trivial and obvious fix for JDK-8291461. Reproducer passes with this fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1459/head:pull/1459
$ git checkout pull/1459

Update a local copy of the PR:
$ git checkout pull/1459
$ git pull https://git.openjdk.org/jdk11u-dev pull/1459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1459

View PR using the GUI difftool:
$ git pr show -t 1459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1459.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2022

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8291461: assert(false) failed: bad AD file

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8fadf3d: 8292158: AES-CTR cipher state corruption with AVX-512

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2022
@TheRealMDoerr TheRealMDoerr changed the title 8295289: assert(false) failed: bad AD file Backport JDK-8291461 Oct 14, 2022
@openjdk openjdk bot changed the title Backport JDK-8291461 8291461: assert(false) failed: bad AD file Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added the backport label Oct 14, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

Going to push as commit b092d77.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 7a90ff2: 8289043: C2: Vector constant materialization attempt
  • 3dec4fc: 8293672: Update freetype md file
  • 887eed3: 8290529: C2: assert(BoolTest(btest).is_canonical()) failure
  • e8b7e77: 8227651: Tests fail with SSLProtocolException: Input record too big
  • 9b7f3f9: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 192179e: 8169187: [macosx] Aqua: java/awt/image/multiresolution/MultiresolutionIconTest.java
  • 7655988: 8284358: Unreachable loop is not removed from C2 IR, leading to a broken graph
  • 7a7b3df: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows
  • b77b0b5: 8285305: Create an automated test for JDK-4495286
  • bc2d8cc: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/16a4bd3dcc3da08f82af305a04d5fe8e2c126e5e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2022
@openjdk openjdk bot closed this Oct 17, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8295289_C2_MulReductionVLNode branch October 17, 2022 05:49
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@TheRealMDoerr Pushed as commit b092d77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants