Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8295322: Tests for JDK-8271459 were not backported to 11u #1460

Closed
wants to merge 5 commits into from
Closed

8295322: Tests for JDK-8271459 were not backported to 11u #1460

wants to merge 5 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Oct 14, 2022 •
edited by openjdk bot

Hi!

Here is a portion of tests from JDK-8271459 adopted to the 11. Original tests were not backported to the 11 because of the fact they use IR test framework that does not exists in the 11.

Verified on amd64/20.04LTS:

7 of 7 new tests PASS on 844c504
4 of 7 new tests FAIL on the previous 4940e2e

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295322: Tests for JDK-8271459 were not backported to 11u

Reviewers

Contributors

  • Christian Hagedorn <chagedorn@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1460/head:pull/1460
$ git checkout pull/1460

Update a local copy of the PR:
$ git checkout pull/1460
$ git pull https://git.openjdk.org/jdk11u-dev pull/1460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1460

View PR using the GUI difftool:
$ git pr show -t 1460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1460.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@apavlyutkin apavlyutkin changed the title 8295322: adds tests for StringBuilder of negative capacity Tests for JDK-8271459 were not backported to 11u Oct 14, 2022
@apavlyutkin
Copy link
Contributor Author

apavlyutkin commented Oct 14, 2022 •
edited

/contributor add chhagedorn

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@apavlyutkin Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@apavlyutkin
Copy link
Contributor Author

/contributor add chhagedorn

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@apavlyutkin chhagedorn was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

⚠️ @apavlyutkin This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@apavlyutkin apavlyutkin changed the title Tests for JDK-8271459 were not backported to 11u 8295322: Tests for JDK-8271459 were not backported to 11u Oct 14, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2022 •
edited

Webrevs

@apavlyutkin
Copy link
Contributor Author

/contributor add Christian Hagedorn chagedorn@openjdk.org

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@apavlyutkin
Contributor Christian Hagedorn <chagedorn@openjdk.org> successfully added.

phohensee
phohensee reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as is, but seems to be a completely new test. Are there tests which could be backported that include the functionality in this new test?

@apavlyutkin
Copy link
Contributor Author

This looks fine as is, but seems to be a completely new test. Are there tests which could be backported that include the functionality in this new test?

Here you are openjdk/jdk@3953e07#diff-23a7c0bc2991c82f3ab4be6a23789dc57829aa5a399c70b9328479d5a9c88850

phohensee
phohensee approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Lgtm. :)

@openjdk
Copy link

openjdk bot commented Oct 20, 2022 •
edited

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295322: Tests for JDK-8271459 were not backported to 11u

Co-authored-by: Christian Hagedorn <chagedorn@openjdk.org>
Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2022
@apavlyutkin
Copy link
Contributor Author

Thank you. Lgtm. :)

Thank you for the review

@apavlyutkin
Copy link
Contributor Author

/integrate

@yan-too
Copy link

yan-too commented Oct 25, 2022

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@apavlyutkin
Your change (at version 17c48cb) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit 70ddb1b.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@yan-too @apavlyutkin Pushed as commit 70ddb1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
3 participants
@apavlyutkin @yan-too @phohensee