8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

[earthling-amzn]

JDK-8288445
AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Backport is not clean, but is not complicated. Some of the instructions patched in later releases do not exist in 11. The test passes before and after the patch is applied.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1462/head:pull/1462
$ git checkout pull/1462

Update a local copy of the PR:
$ git checkout pull/1462
$ git pull https://git.openjdk.org/jdk11u-dev pull/1462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1462

View PR using the GUI difftool:
$ git pr show -t 1462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1462.diff

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (2427b787)

[GoeLin]

Hi, next time, please only label fix-request if your PR is ready. In this case the review is missing.

[phohensee]

Lgtm. Even though the test succeeds without the backport, probably because something in C2 is masking the problem, imo it's good code hygiene to fix it.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 5465105: 8295641: Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev
• bd92c2f: Merge
• 69ce82b: 8295057: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.17
• 1d94bc4: 8286918: Better HttpServer service
• bdd9017: 8286519: Better memory handling
• cf0812d: 8286511: Improve macro allocation
• 1c70f54: 8288508: Enhance ECDSA usage
• 0db04ee: 8286910: Improve JNDI lookups
• 79dc540: 8289366: Improve HTTP/2 client usage
• 7548ffa: 8287446: Enhance icon presentations
• ... and 27 more: https://git.openjdk.org/jdk11u-dev/compare/16a4bd3dcc3da08f82af305a04d5fe8e2c126e5e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version 2427b78) is now ready to be sponsored by a Committer.

[phohensee]

/integrate

[openjdk]

@phohensee Only the author (@earthling-amzn) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[phohensee]

/sponsor

[openjdk]

Going to push as commit a2b2a22.
Since your change was applied there have been 37 commits pushed to the master branch:

• 5465105: 8295641: Fix DEFAULT_PROMOTED_VERSION_PRE=ea for -dev
• bd92c2f: Merge
• 69ce82b: 8295057: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.17
• 1d94bc4: 8286918: Better HttpServer service
• bdd9017: 8286519: Better memory handling
• cf0812d: 8286511: Improve macro allocation
• 1c70f54: 8288508: Enhance ECDSA usage
• 0db04ee: 8286910: Improve JNDI lookups
• 79dc540: 8289366: Improve HTTP/2 client usage
• 7548ffa: 8287446: Enhance icon presentations
• ... and 27 more: https://git.openjdk.org/jdk11u-dev/compare/16a4bd3dcc3da08f82af305a04d5fe8e2c126e5e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @earthling-amzn Pushed as commit a2b2a22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.