Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295469: S390X: Optimized builds are broken #1466

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 20, 2022

Fixes S390X optimized builds.

Additional testing:

  • Linux S390X {fastdebug, release, optimized} builds

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1466/head:pull/1466
$ git checkout pull/1466

Update a local copy of the PR:
$ git checkout pull/1466
$ git pull https://git.openjdk.org/jdk11u-dev pull/1466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1466

View PR using the GUI difftool:
$ git pr show -t 1466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1466.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b2e83b3955c034208325ea5477afd3c5e1da41a 8295469: S390X: Optimized builds are broken Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295469: S390X: Optimized builds are broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

Going to push as commit 37d3bbd.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a2b2a22: 8288445: AArch64: C2 compilation fails with guarantee(!true || (true && (shift != 0))) failed: impossible encoding

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2022
@openjdk openjdk bot closed this Oct 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2022
@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@shipilev Pushed as commit 37d3bbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant