Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261336: IGV: enhance default filters #1468

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 24, 2022

I backport this for parity with 11.0.18-oracle.

I resolved copyrights in type.c/hpp
I replaced enum class Category in type.hpp by an old style enum.
I had to exclude VectorA in a switch as it is not introduced in 11 yet.
Unfortunately, layer.xml contains trailing white space in the original patch.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1468/head:pull/1468
$ git checkout pull/1468

Update a local copy of the PR:
$ git checkout pull/1468
$ git pull https://git.openjdk.org/jdk11u-dev pull/1468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1468

View PR using the GUI difftool:
$ git pr show -t 1468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1468.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 16bd7d381f498ed659d2b1b372458d86fbbef275 8261336: IGV: enhance default filters Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 24, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261336: IGV: enhance default filters

Add filters to color and hide parts of the graph based on node categories or
estimated execution frequency, and simplify remaining filters.

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Oct 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit d30cbeb.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 19b9fde: 8228672: [TESTBUG] gc/metaspace/TestSizeTransitions.java fails on 32-bit platforms
  • 70ddb1b: 8295322: Tests for JDK-8271459 were not backported to 11u
  • 8608557: 8227179: Test for new gc+metaspace=info output format
  • 87853b0: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@GoeLin Pushed as commit d30cbeb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8261336 branch October 25, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants