Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295554: Move the "sizecalc.h" to the correct location #1476

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 26, 2022

Hi all,
This pull request contains a backport of commit 6673cd85 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295554: Move the "sizecalc.h" to the correct location

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1476/head:pull/1476
$ git checkout pull/1476

Update a local copy of the PR:
$ git checkout pull/1476
$ git pull https://git.openjdk.org/jdk11u-dev pull/1476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1476

View PR using the GUI difftool:
$ git pr show -t 1476

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1476.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6673cd857722d117b108590ba7f7c02f8622fc3b 8295554: Move the "sizecalc.h" to the correct location Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 26, 2022
@mrserb mrserb marked this pull request as ready for review October 27, 2022 00:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Oct 27, 2022

/clean only the path to the makefile is changed

@openjdk openjdk bot added the clean label Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295554: Move the "sizecalc.h" to the correct location

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2022
@mrserb
Copy link
Member Author

mrserb commented Nov 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 188ab59.
Since your change was applied there have been 20 commits pushed to the master branch:

  • f24340a: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
  • 6b2e6ae: 8282730: LdapLoginModule throw NPE from logout method after login failure
  • d403e0d: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 13c07e6: 8257722: Improve "keytool -printcert -jarfile" output
  • 7c5f9c6: 8295429: Update harfbuzz md file
  • 3b40d21: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • 182173a: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 91f1538: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 82c9cf2: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied
  • 5c454ae: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/3c1e0cf887336bcf74314b5cfd4a97c7cc12b91b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@mrserb mrserb deleted the mrserb-backport-6673cd85 branch November 4, 2022 08:21
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@mrserb Pushed as commit 188ab59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant