8280550: SplittableRandom#nextDouble(double,double) can return result >= bound

[GoeLin]

The original fix patches jdk/internal/util/random/RandomSupport.java.
This class is not in 11.

The Random code was completely reworked by
"8248862: Implement Enhanced Pseudo-Random Number Generators"
In the old 11 code there are several methods 'nextDouble' or
'internalNextDouble' all using the same pattern. They were
replaced by the implementation in the new class
RandomSupport in 17.

I adapted the following methods:
in java/util/Random.java:
final double internalNextDouble(double origin, double bound)

in java/util/SplittableRandom.java
final double internalNextDouble(double origin, double bound)
public double nextDouble(double bound)

in java/util/concurrent/ThreadLocalRandom.java
final double internalNextDouble(double origin, double bound)
public double nextDouble(double bound)

I think this are all affected methods, but please double-check.

The change requires follow-up 8280950 which needs to be
adapted to touch the three internalNextDouble()
methods.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8280550: SplittableRandom#nextDouble(double,double) can return result >= bound

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1478/head:pull/1478
$ git checkout pull/1478

Update a local copy of the PR:
$ git checkout pull/1478
$ git pull https://git.openjdk.org/jdk11u-dev pull/1478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1478

View PR using the GUI difftool:
$ git pr show -t 1478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1478.diff

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (239be65e)
• 01: Full - Incremental (e884b536)
• 00: Full (d43bf1d1)

[phohensee]

There's similar code in java.desktop/share/classes/sun/awt/geom/Curve.java, but it hasn't been updated in tip, so lgtm.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280550: SplittableRandom#nextDouble(double,double) can return result >= bound

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 5c454ae: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
• b928a88: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
• 7067c7c: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
• 1f618ab: 8285373: Create an automated test for JDK-4702233
• b9b5e52: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
• 429cbc4: 8295288: Some vm_flags tests associate with a wrong BugID
• 0b0529e: 8280948: Write a regression test for JDK-4659800
• 0f08e3c: 8282402: Create a regression test for JDK-4666101
• 5ecd16d: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
• 18631ef: 8280158: New test from JDK-8274736 failed with/without patch in JDK11u
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/3c1e0cf887336bcf74314b5cfd4a97c7cc12b91b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

Good catch of this further appearance. I agree the fix is not needed there. But the methods there might not always deliver the previous double either.

[phohensee]

Perhaps file a bug against tip, fix it, and backport.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 91f1538.
Since your change was applied there have been 12 commits pushed to the master branch:

• 82c9cf2: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied
• 5c454ae: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
• b928a88: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
• 7067c7c: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
• 1f618ab: 8285373: Create an automated test for JDK-4702233
• b9b5e52: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
• 429cbc4: 8295288: Some vm_flags tests associate with a wrong BugID
• 0b0529e: 8280948: Write a regression test for JDK-4659800
• 0f08e3c: 8282402: Create a regression test for JDK-4666101
• 5ecd16d: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
• ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/3c1e0cf887336bcf74314b5cfd4a97c7cc12b91b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 91f1538.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[GoeLin]

I opened JDK-8296402 for the pattern in Curve.java.