New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261445: Use memory_order_relaxed for os::random(). #1480
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@Rudometov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.
|
/integrate |
@Rudometov |
/sponsor |
Going to push as commit df9c46a.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit df9c46a. |
Backport https://bugs.openjdk.org/browse/JDK-8261445 Use memory_order_relaxed for os::random() for jdk11u
Backport not clean, however the change is trivial.
Tested in linux x64/aarch64: tier1, tier2, jck's passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1480/head:pull/1480
$ git checkout pull/1480
Update a local copy of the PR:
$ git checkout pull/1480
$ git pull https://git.openjdk.org/jdk11u-dev pull/1480/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1480
View PR using the GUI difftool:
$ git pr show -t 1480
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1480.diff