Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261445: Use memory_order_relaxed for os::random(). #1480

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 26, 2022

Backport https://bugs.openjdk.org/browse/JDK-8261445 Use memory_order_relaxed for os::random() for jdk11u

Backport not clean, however the change is trivial.
Tested in linux x64/aarch64: tier1, tier2, jck's passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261445: Use memory_order_relaxed for os::random().

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1480/head:pull/1480
$ git checkout pull/1480

Update a local copy of the PR:
$ git checkout pull/1480
$ git pull https://git.openjdk.org/jdk11u-dev pull/1480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1480

View PR using the GUI difftool:
$ git pr show -t 1480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1480.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a25bae823979fc96d01a2e349506ed3b1ea39762 8261445: Use memory_order_relaxed for os::random(). Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261445: Use memory_order_relaxed for os::random().

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 8f5ae91: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • f07e691: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ca988a6: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints
  • 188ab59: 8295554: Move the "sizecalc.h" to the correct location
  • f24340a: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
  • 6b2e6ae: 8282730: LdapLoginModule throw NPE from logout method after login failure
  • d403e0d: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 13c07e6: 8257722: Improve "keytool -printcert -jarfile" output
  • 7c5f9c6: 8295429: Update harfbuzz md file
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/3c1e0cf887336bcf74314b5cfd4a97c7cc12b91b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@Rudometov
Your change (at version 655d984) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

Going to push as commit df9c46a.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 8f5ae91: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • f07e691: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ca988a6: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints
  • 188ab59: 8295554: Move the "sizecalc.h" to the correct location
  • f24340a: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
  • 6b2e6ae: 8282730: LdapLoginModule throw NPE from logout method after login failure
  • d403e0d: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 13c07e6: 8257722: Improve "keytool -printcert -jarfile" output
  • 7c5f9c6: 8295429: Update harfbuzz md file
  • ... and 15 more: https://git.openjdk.org/jdk11u-dev/compare/3c1e0cf887336bcf74314b5cfd4a97c7cc12b91b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2022
@openjdk openjdk bot closed this Nov 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@phohensee @Rudometov Pushed as commit df9c46a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the Backport-JDK-8261445 branch January 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants