Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285373: Create an automated test for JDK-4702233 #1483

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 26, 2022

Backport of
JDK-8285373 Create an automated test for JDK-4702233

First backport adds a test, that does not compile, second backport fixes the test.

Clean backport, trivial, low risk - new test.
tests pass during manual run after second backport pr commit


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1483/head:pull/1483
$ git checkout pull/1483

Update a local copy of the PR:
$ git checkout pull/1483
$ git pull https://git.openjdk.org/jdk11u-dev pull/1483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1483

View PR using the GUI difftool:
$ git pr show -t 1483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1483.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 005a330387b8ee1179d1be31b53ea2c5d49c32f8 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 27, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@Rudometov
Adding additional issue to issue list: 8285373: Create an automated test for JDK-4702233.

@Rudometov Rudometov changed the title 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile Backport 6f526e1bc3e0af4189fbb7d3b48d614717f266b0 Oct 27, 2022
@openjdk openjdk bot changed the title Backport 6f526e1bc3e0af4189fbb7d3b48d614717f266b0 8285373: Create an automated test for JDK-4702233 Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk-notifier
Copy link

@Rudometov Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285373: Create an automated test for JDK-4702233
8285373: Create an automated test for JDK-4702233

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@Rudometov
Your change (at version dcaa02c) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

Going to push as commit 1f618ab.
Since your change was applied there have been 7 commits pushed to the master branch:

  • b9b5e52: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 429cbc4: 8295288: Some vm_flags tests associate with a wrong BugID
  • 0b0529e: 8280948: Write a regression test for JDK-4659800
  • 0f08e3c: 8282402: Create a regression test for JDK-4666101
  • 5ecd16d: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 18631ef: 8280158: New test from JDK-8274736 failed with/without patch in JDK11u
  • cb5e611: 8222251: preflow visitor is not visiting lambda expressions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2022
@openjdk openjdk bot closed this Oct 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@phohensee @Rudometov Pushed as commit 1f618ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8285373 branch January 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants