-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285373: Create an automated test for JDK-4702233 #1483
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@Rudometov |
This backport pull request has now been updated with issue from the original commit. |
@Rudometov Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
@Rudometov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@Rudometov |
/sponsor |
Going to push as commit 1f618ab.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit 1f618ab. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of
JDK-8285373 Create an automated test for JDK-4702233
First backport adds a test, that does not compile, second backport fixes the test.
Clean backport, trivial, low risk - new test.
tests pass during manual run after second backport pr commit
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1483/head:pull/1483
$ git checkout pull/1483
Update a local copy of the PR:
$ git checkout pull/1483
$ git pull https://git.openjdk.org/jdk11u-dev pull/1483/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1483
View PR using the GUI difftool:
$ git pr show -t 1483
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1483.diff