New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile #1485
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@Rudometov Only OpenJDK Committers can use the |
It seems the dependency chain is not set for this PR so the diff contains both fixed. |
As mrserb implied, please update the patch. Once you do that, and assuming the backport is clean, add /integrate and one of us can sponsor. |
@Rudometov Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
@Rudometov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Some checks hanged (actually stopped, but here it displays as in progress). I've run them separately (https://github.com/Rudometov/jdk11u-dev/actions/runs/3367115972) all green. |
/integrate |
@Rudometov |
/sponsor |
@phohensee @Rudometov Pushed as commit 5c454ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of
JDK-8287826 javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile
This is second backport in a series that fixes the test first backport added.
Clean backport, trivial, low risk - new test update.
tests pass during manual run
This pr depends on this pr: #1483
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1485/head:pull/1485
$ git checkout pull/1485
Update a local copy of the PR:
$ git checkout pull/1485
$ git pull https://git.openjdk.org/jdk11u-dev pull/1485/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1485
View PR using the GUI difftool:
$ git pr show -t 1485
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1485.diff