Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile #1485

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 27, 2022

Backport of
JDK-8287826 javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile

This is second backport in a series that fixes the test first backport added.

Clean backport, trivial, low risk - new test update.
tests pass during manual run

This pr depends on this pr: #1483


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1485/head:pull/1485
$ git checkout pull/1485

Update a local copy of the PR:
$ git checkout pull/1485
$ git pull https://git.openjdk.org/jdk11u-dev pull/1485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1485

View PR using the GUI difftool:
$ git pr show -t 1485

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1485.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 005a330387b8ee1179d1be31b53ea2c5d49c32f8 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 27, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2022

Webrevs

@Rudometov
Copy link
Member Author

/clean

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@Rudometov Only OpenJDK Committers can use the /clean command

@mrserb
Copy link
Member

mrserb commented Oct 29, 2022

It seems the dependency chain is not set for this PR so the diff contains both fixed.

@phohensee
Copy link
Member

As mrserb implied, please update the patch. Once you do that, and assuming the backport is clean, add /integrate and one of us can sponsor.

@openjdk-notifier
Copy link

@Rudometov Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b928a88: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 31, 2022
@Rudometov
Copy link
Member Author

Some checks hanged (actually stopped, but here it displays as in progress). I've run them separately (https://github.com/Rudometov/jdk11u-dev/actions/runs/3367115972) all green.

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@Rudometov
Your change (at version 14ee72d) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

Going to push as commit 5c454ae.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b928a88: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2022
@openjdk openjdk bot closed this Nov 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@phohensee @Rudometov Pushed as commit 5c454ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8287826 branch January 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants