Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 #1486

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 28, 2022

Backport from 17u to 11u
JDK-8296008 Problem list 4 jtreg tests which regularly fail on macos-aarch64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1486/head:pull/1486
$ git checkout pull/1486

Update a local copy of the PR:
$ git checkout pull/1486
$ git pull https://git.openjdk.org/jdk11u-dev pull/1486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1486

View PR using the GUI difftool:
$ git pr show -t 1486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1486.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2e9ef14ee4c9ead29cb50f424df698069ee93332 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 28, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 29, 2022

@Rudometov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 0b0529e: 8280948: Write a regression test for JDK-4659800
  • 0f08e3c: 8282402: Create a regression test for JDK-4666101
  • 5ecd16d: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 18631ef: 8280158: New test from JDK-8274736 failed with/without patch in JDK11u
  • cb5e611: 8222251: preflow visitor is not visiting lambda expressions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2022
@openjdk
Copy link

openjdk bot commented Oct 30, 2022

@Rudometov
Your change (at version a947801) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Oct 30, 2022
@mrserb
Copy link
Member

mrserb commented Oct 30, 2022

The backport is not yet approved in JBS.

@GoeLin
Copy link
Member

GoeLin commented Oct 31, 2022

Yes, you should only integrate if you have the approval. But now it is there :)

@GoeLin
Copy link
Member

GoeLin commented Oct 31, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

Going to push as commit 7067c7c.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 1f618ab: 8285373: Create an automated test for JDK-4702233
  • b9b5e52: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 429cbc4: 8295288: Some vm_flags tests associate with a wrong BugID
  • 0b0529e: 8280948: Write a regression test for JDK-4659800
  • 0f08e3c: 8282402: Create a regression test for JDK-4666101
  • 5ecd16d: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 18631ef: 8280158: New test from JDK-8274736 failed with/without patch in JDK11u
  • cb5e611: 8222251: preflow visitor is not visiting lambda expressions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2022
@openjdk openjdk bot closed this Oct 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@GoeLin @Rudometov Pushed as commit 7067c7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8296008 branch January 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants