Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix #1487

Closed
wants to merge 6 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 31, 2022

I had to do similar resolves as in the underlying change JDK-8280550.

In the test, I had to remove RandomGenerator which is not in 11.
The same pattern can not be implemented with SplittableRandom as it is final.
Thus, the test is no more deterministic. It depends on whether the
rounding error actually occurs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1487/head:pull/1487
$ git checkout pull/1487

Update a local copy of the PR:
$ git checkout pull/1487
$ git pull https://git.openjdk.org/jdk11u-dev pull/1487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1487

View PR using the GUI difftool:
$ git pr show -t 1487

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1487.diff

@GoeLin GoeLin changed the base branch from master to pr/1478 October 31, 2022 17:26
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/1478 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e70d4504c267174738485c7da82a2ac0ef09770 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 31, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1478 to master November 3, 2022 14:16
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8280950
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@GoeLin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout goetz_backport_8280950
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Nov 3, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Nov 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

Going to push as commit 182173a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022
@openjdk openjdk bot closed this Nov 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@GoeLin Pushed as commit 182173a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8280950 branch November 3, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants