-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277497: Last column cell in the JTable row is read as empty cell #1490
8277497: Last column cell in the JTable row is read as empty cell #1490
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@earthling-amzn This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@earthling-amzn |
Hi @earthling-amzn, you should not integrate if you don not have the jdk11u-fix-yes label. How did you test the backport? |
Removing the tag for now. |
I tested the change on MacOS following the instructions in the original bug report, and I can confirm that the table cell that has been read falsely as 'null' is now correctly being read as 'image'. |
Thanks! |
Going to push as commit 03fa471.
Your commit was automatically rebased without conflicts. |
@GoeLin @earthling-amzn Pushed as commit 03fa471. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 70bad89b from the openjdk/jdk repository.
The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1490/head:pull/1490
$ git checkout pull/1490
Update a local copy of the PR:
$ git checkout pull/1490
$ git pull https://git.openjdk.org/jdk11u-dev pull/1490/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1490
View PR using the GUI difftool:
$ git pr show -t 1490
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1490.diff