Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277497: Last column cell in the JTable row is read as empty cell #1490

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Nov 1, 2022

Hi all,

This pull request contains a backport of commit 70bad89b from the openjdk/jdk repository.

The commit being backported was authored by Artem Semenov on 6 Dec 2021 and was reviewed by Anton Tarasov, Alexander Zuev and Pankaj Bansal. This backport brings parity with oracle 11.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277497: Last column cell in the JTable row is read as empty cell

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1490/head:pull/1490
$ git checkout pull/1490

Update a local copy of the PR:
$ git checkout pull/1490
$ git pull https://git.openjdk.org/jdk11u-dev pull/1490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1490

View PR using the GUI difftool:
$ git pr show -t 1490

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1490.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2022

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 70bad89b012eb200ca1e76f384a6e5fb307cf26d 8277497: Last column cell in the JTable row is read as empty cell Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@earthling-amzn This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277497: Last column cell in the JTable row is read as empty cell

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5c454ae: 8287826: javax/accessibility/4702233/AccessiblePropertiesTest.java fails to compile

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2022

Webrevs

@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@earthling-amzn
Your change (at version b8f9ade) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 2, 2022

Hi @earthling-amzn, you should not integrate if you don not have the jdk11u-fix-yes label.
Please follow https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+a+fix

How did you test the backport?

@GoeLin
Copy link
Member

GoeLin commented Nov 8, 2022

Removing the tag for now.

@rkennke
Copy link
Contributor

rkennke commented Nov 10, 2022

I tested the change on MacOS following the instructions in the original bug report, and I can confirm that the table cell that has been read falsely as 'null' is now correctly being read as 'image'.

@GoeLin
Copy link
Member

GoeLin commented Nov 11, 2022

Thanks!
/sponsor

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

Going to push as commit 03fa471.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 7c664bc: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
  • ca885ee: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • dde20e4: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 6664437: 8268361: Fix the infinite loop in next_line
  • c09c433: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 03e1247: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • df9c46a: 8261445: Use memory_order_relaxed for os::random().
  • 8f5ae91: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • f07e691: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/b928a88fd564fab88f00086a62c0695ed5cc9353...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2022
@openjdk openjdk bot closed this Nov 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@GoeLin @earthling-amzn Pushed as commit 03fa471.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants