Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282730: LdapLoginModule throw NPE from logout method after login failure #1491

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 2, 2022

I backport this for parity with 11.0.18-oracle.

I had to resolve 6 Copyrights. Will mark as clean.

Copyrights in these files:
src/java.base/share/classes/javax/security/auth/login/LoginContext.java
src/java.management/share/classes/com/sun/jmx/remote/security/FileLoginModule.java
src/jdk.security.auth/share/classes/com/sun/security/auth/module/JndiLoginModule.java
src/jdk.security.auth/share/classes/com/sun/security/auth/module/LdapLoginModule.java
src/jdk.security.auth/share/classes/com/sun/security/auth/module/NTLoginModule.java
src/jdk.security.auth/share/classes/com/sun/security/auth/module/UnixLoginModule.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282730: LdapLoginModule throw NPE from logout method after login failure

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1491/head:pull/1491
$ git checkout pull/1491

Update a local copy of the PR:
$ git checkout pull/1491
$ git pull https://git.openjdk.org/jdk11u-dev pull/1491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1491

View PR using the GUI difftool:
$ git pr show -t 1491

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1491.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 554f44ecb1134acff3eaf02e2e1c0e01158ab7e5 8282730: LdapLoginModule throw NPE from logout method after login failure Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 2, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Nov 3, 2022

/clean

@openjdk openjdk bot added the clean label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282730: LdapLoginModule throw NPE from logout method after login failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 82c9cf2: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Nov 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 6b2e6ae.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d403e0d: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 13c07e6: 8257722: Improve "keytool -printcert -jarfile" output
  • 7c5f9c6: 8295429: Update harfbuzz md file
  • 3b40d21: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
  • 182173a: 8280950: RandomGenerator:NextDouble() default behavior non conformant after JDK-8280550 fix
  • 91f1538: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
  • 82c9cf2: 8199290: [TESTBUG] sun.hotspot.WhiteBox$WhiteBoxPermission is not copied

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@GoeLin Pushed as commit 6b2e6ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8282730 branch November 4, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant