Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295714: GHA ::set-output is deprecated and will be removed #1494

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Nov 2, 2022

This backport fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`

All tests passed (no warnings).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295714: GHA ::set-output is deprecated and will be removed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1494/head:pull/1494
$ git checkout pull/1494

Update a local copy of the PR:
$ git checkout pull/1494
$ git pull https://git.openjdk.org/jdk11u-dev pull/1494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1494

View PR using the GUI difftool:
$ git pr show -t 1494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1494.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@zzambers zzambers changed the title Avoid use of deprecated ::set-output in GHA Backport b35922be6de7b848a2982d6a278dbd205fc39e6a Nov 8, 2022
@openjdk openjdk bot changed the title Backport b35922be6de7b848a2982d6a278dbd205fc39e6a 8295714: GHA ::set-output is deprecated and will be removed Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295714: GHA ::set-output is deprecated and will be removed

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • ca885ee: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • dde20e4: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 6664437: 8268361: Fix the infinite loop in next_line
  • c09c433: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 03e1247: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • df9c46a: 8261445: Use memory_order_relaxed for os::random().
  • 8f5ae91: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • f07e691: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ca988a6: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints
  • ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/b928a88fd564fab88f00086a62c0695ed5cc9353...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2022
@zzambers
Copy link
Contributor Author

zzambers commented Nov 9, 2022

@phohensee Thanks
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@zzambers
Your change (at version 12ede6d) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 14, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

Going to push as commit 5d28a71.
Since your change was applied there have been 26 commits pushed to the master branch:

  • d2af653: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 3b7f045: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • 338f9af: 8255439: System Tray icons get corrupted when Windows scaling changes
  • 03fa471: 8277497: Last column cell in the JTable row is read as empty cell
  • 7c664bc: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access
  • ca885ee: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • dde20e4: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 6664437: 8268361: Fix the infinite loop in next_line
  • c09c433: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 03e1247: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • ... and 16 more: https://git.openjdk.org/jdk11u-dev/compare/b928a88fd564fab88f00086a62c0695ed5cc9353...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2022
@openjdk openjdk bot closed this Nov 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@jerboaa @zzambers Pushed as commit 5d28a71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants