Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" #1499

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 3, 2022

Backport of JDK-8277970.
I had to trivially resolve because JDK-8282723 is not in 11u. Let's see whether the bots will flag it as clean...


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1499/head:pull/1499
$ git checkout pull/1499

Update a local copy of the PR:
$ git checkout pull/1499
$ git pull https://git.openjdk.org/jdk11u-dev pull/1499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1499

View PR using the GUI difftool:
$ git pr show -t 1499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1499.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d1252653b07ee3d0347b39b96f734e45772b5b36 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch" Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

Going to push as commit f07e691.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ca988a6: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints
  • 188ab59: 8295554: Move the "sizecalc.h" to the correct location
  • f24340a: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
  • 6b2e6ae: 8282730: LdapLoginModule throw NPE from logout method after login failure
  • d403e0d: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 13c07e6: 8257722: Improve "keytool -printcert -jarfile" output

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2022
@openjdk openjdk bot closed this Nov 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2022
@RealCLanger RealCLanger deleted the RealCLanger-backport-d1252653 branch November 7, 2022 14:01
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@RealCLanger Pushed as commit f07e691.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant