Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259535: ECDSA SignatureValue do not always have the specified length #150

Closed
wants to merge 2 commits into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jul 21, 2021

Clean backport of JDK-8259535. Only test needs replacement for HexFormat.ofDelimiter(":").formatHex(sig) which is not available in 11u. Included test fails without this fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259535: ECDSA SignatureValue do not always have the specified length

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/150/head:pull/150
$ git checkout pull/150

Update a local copy of the PR:
$ git checkout pull/150
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 150

View PR using the GUI difftool:
$ git pr show -t 150

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/150.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a4c249610e7c0fcc7fd863f14f51c96abc5ca39f 8259535: ECDSA SignatureValue do not always have the specified length Jul 21, 2021
@openjdk
Copy link

openjdk bot commented Jul 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 21, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259535: ECDSA SignatureValue do not always have the specified length

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • 2b3a641: 8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 23, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review and the approval!
/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2021

Going to push as commit 63c4ec2.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • 2b3a641: 8245134: test/lib/jdk/test/lib/security/KeyStoreUtils.java should allow to specify aliases

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2021
@openjdk
Copy link

openjdk bot commented Jul 23, 2021

@TheRealMDoerr Pushed as commit 63c4ec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8259535_ECDSA branch July 23, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants