Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures #1501

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 4, 2022

11u-dev backport of 8292866


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1501/head:pull/1501
$ git checkout pull/1501

Update a local copy of the PR:
$ git checkout pull/1501
$ git pull https://git.openjdk.org/jdk11u-dev pull/1501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1501

View PR using the GUI difftool:
$ git pr show -t 1501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1501.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 699c42962eeaa6aa950ad86c2dd1f77316a1da3e 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 4, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2022

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted Copyright, which is already updated.
LGTM

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • df9c46a: 8261445: Use memory_order_relaxed for os::random().
  • 8f5ae91: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • f07e691: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ca988a6: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2022
@GoeLin
Copy link
Member

GoeLin commented Nov 8, 2022

Hi, you should have the issue reviewed before labeling it.
(This one would have qualified for a /clean command after motivating it.

@MBaesken
Copy link
Member Author

MBaesken commented Nov 8, 2022

Thanks for the review !

@MBaesken
Copy link
Member Author

MBaesken commented Nov 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit c09c433.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 03e1247: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • df9c46a: 8261445: Use memory_order_relaxed for os::random().
  • 8f5ae91: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • f07e691: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 3e3f665: 8293826: Closed test fails after JDK-8276108 on aarch64
  • ca988a6: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@MBaesken Pushed as commit c09c433.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants