New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures #1501
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitted Copyright, which is already updated.
LGTM
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Hi, you should have the issue reviewed before labeling it. |
Thanks for the review ! |
/integrate |
Going to push as commit c09c433.
Your commit was automatically rebased without conflicts. |
11u-dev backport of 8292866
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1501/head:pull/1501
$ git checkout pull/1501
Update a local copy of the PR:
$ git checkout pull/1501
$ git pull https://git.openjdk.org/jdk11u-dev pull/1501/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1501
View PR using the GUI difftool:
$ git pr show -t 1501
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1501.diff