8256109: Create implementation for NSAccessibilityButton protocol

[Autumn808]

Preparing to backport JDK-8256109, Mostly clean, changed the copyright date and fixed some empty line conflicts. This is part of broader group of changes as part of JDK-8152350.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8256109: Create implementation for NSAccessibilityButton protocol

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1505/head:pull/1505
$ git checkout pull/1505

Update a local copy of the PR:
$ git checkout pull/1505
$ git pull https://git.openjdk.org/jdk11u-dev pull/1505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1505

View PR using the GUI difftool:
$ git pr show -t 1505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1505.diff

[bridgekeeper]

Hi @Autumn808, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Autumn808" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[Autumn808]

/covered

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[phohensee]

I can confirm that Autumn is an Amazon employee and therefore covered under the OCA.

[mlbridge]

Webrevs

• 00: Full (575ab6f7)

[phohensee]

The backport looks fine, but how did you test it? Also, do you intend to backport the whole sequence from JDK-8152350?

[Autumn808]

I tested it buy building a button and testing to make sure the accessibility voice features still work with my changes. I do intend to do them all.

[phohensee]

Thank you and lgtm. I recommend you do the backports in chronological order of commit dates. There's a conflict in this PR where the original commit includes the removal of the CommonComponentAccessibility declaration in JavaComponentAccessibility.m that isn't needed in this PR, because I suspect it wasn't backported first.

[openjdk]

⚠️ @Autumn808 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8264302
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@Autumn808 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256109: Create implementation for NSAccessibilityButton protocol

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 55354dd: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
• 1549bb1: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
• b7b00f7: 8296108: (tz) Update Timezone Data to 2022f
• e3eccbc: 8294307: ISO 4217 Amendment 173 Update
• 954a6e4: 8286872: Refactor add/modify notification icon (TrayIcon)
• f2f7be9: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
• 8a40a9c: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
• 7e0603f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• 5d28a71: 8295714: GHA ::set-output is deprecated and will be removed
• d2af653: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
• ... and 14 more: https://git.openjdk.org/jdk11u-dev/compare/188ab5910fb51af83ad64b3fea3205522f110aac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[phohensee]

Tagged the JBS issue.

[Autumn808]

fixed I added my full name.

[GoeLin]

Hi,
I appreciate a lot that you are addressing this.
As Paul said, it makes sense to work them in the order they were pushed originally to avoid unnecessary conflicts.
There are also quite a lot of related follow up fixes and test fixes.
This filter https://bugs.openjdk.org/issues/?filter=43450 gives you a list of the
changes brought to 11.0.17-oracle and 11.0.18-oracle which are not yet in open jdk11u.
If you work this list bottom up, you get the order they were pushed originally
This is a good starting point. You may find more issues that are related.

[Autumn808]

Thank you so much I will follow that advice.

[Autumn808]

/integrate

[openjdk]

@Autumn808
Your change (at version 575ab6f) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 5043784.
Since your change was applied there have been 24 commits pushed to the master branch:

• 55354dd: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
• 1549bb1: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
• b7b00f7: 8296108: (tz) Update Timezone Data to 2022f
• e3eccbc: 8294307: ISO 4217 Amendment 173 Update
• 954a6e4: 8286872: Refactor add/modify notification icon (TrayIcon)
• f2f7be9: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
• 8a40a9c: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
• 7e0603f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
• 5d28a71: 8295714: GHA ::set-output is deprecated and will be removed
• d2af653: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
• ... and 14 more: https://git.openjdk.org/jdk11u-dev/compare/188ab5910fb51af83ad64b3fea3205522f110aac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @Autumn808 Pushed as commit 5043784.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[Autumn808]

@GoeLin Hi, The link you provided is marked as private so cannot accesses the list. Could you provide a list that is accessible so I can start on those backports.