Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268361: Fix the infinite loop in next_line #1508

Closed
wants to merge 1 commit into from

Conversation

jankratochvil
Copy link
Contributor

@jankratochvil jankratochvil commented Nov 8, 2022

There was a backport of the JDK-18 fix to JDK-13, JDK-15 and JDK-17.

Issues

I am not yet an Author - I do not have JBS account.

I have run the testsuite on linux64 and there is no change of the results. There is no new testcase for this fix and I did not do any extra testing of the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1508/head:pull/1508
$ git checkout pull/1508

Update a local copy of the PR:
$ git checkout pull/1508
$ git pull https://git.openjdk.org/jdk11u-dev pull/1508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1508

View PR using the GUI difftool:
$ git pr show -t 1508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1508.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back jankratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jankratochvil jankratochvil changed the title backport 8268361: Fix the infinite loop in next_line Nov 8, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

@jankratochvil jankratochvil changed the title 8268361: Fix the infinite loop in next_line backport 72672277e4dddf8e72f1c705cd5f57de40745635 Nov 8, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 8, 2022
@jankratochvil jankratochvil changed the title backport 72672277e4dddf8e72f1c705cd5f57de40745635 Backport 72672277e4dddf8e72f1c705cd5f57de40745635 Nov 8, 2022
@openjdk openjdk bot changed the title Backport 72672277e4dddf8e72f1c705cd5f57de40745635 8268361: Fix the infinite loop in next_line Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@jankratochvil This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268361: Fix the infinite loop in next_line

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c09c433: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 03e1247: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • df9c46a: 8261445: Use memory_order_relaxed for os::random().

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk-notifier
Copy link

@jankratochvil Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@jankratochvil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@jankratochvil
Your change (at version 11f4f6b) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented Nov 9, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit 6664437.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c09c433: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 03e1247: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • df9c46a: 8261445: Use memory_order_relaxed for os::random().

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@yan-too @jankratochvil Pushed as commit 6664437.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants