-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268361: Fix the infinite loop in next_line #1508
Conversation
👋 Welcome back jankratochvil! A progress list of the required criteria for merging this PR into |
Webrevs
|
This backport pull request has now been updated with issue from the original commit. |
@jankratochvil This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Backport-of: 7267227
9ca71d4
to
11f4f6b
Compare
@jankratochvil Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
/integrate |
@jankratochvil |
/sponsor |
Going to push as commit 6664437.
Your commit was automatically rebased without conflicts. |
@yan-too @jankratochvil Pushed as commit 6664437. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
There was a backport of the JDK-18 fix to JDK-13, JDK-15 and JDK-17.
Issues
I am not yet an Author - I do not have JBS account.
I have run the testsuite on linux64 and there is no change of the results. There is no new testcase for this fix and I did not do any extra testing of the fix.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1508/head:pull/1508
$ git checkout pull/1508
Update a local copy of the PR:
$ git checkout pull/1508
$ git pull https://git.openjdk.org/jdk11u-dev pull/1508/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1508
View PR using the GUI difftool:
$ git pr show -t 1508
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1508.diff